Skip to content

the result of decision procedure is fixed once witnessed is provided #789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 4, 2019
Merged

the result of decision procedure is fixed once witnessed is provided #789

merged 6 commits into from
Jun 4, 2019

Conversation

HuStmpHrrr
Copy link
Member

c.f. #781

@MatthewDaggitt MatthewDaggitt added this to the v1.1 milestone May 26, 2019
gallais
gallais reviewed May 28, 2019
View reviewed changes
gallais
gallais reviewed May 28, 2019
View reviewed changes
@gallais
Copy link
Member

gallais commented May 29, 2019

It's worth refactoring ≡-≟-identity and ≢-≟-identity defined in
Relation.Binary.PropositionalEquality using these results.

@HuStmpHrrr
Copy link
Member Author

HuStmpHrrr commented May 29, 2019 •
edited
Loading

It's worth refactoring ≡-≟-identity and ≢-≟-identity defined in
Relation.Binary.PropositionalEquality using these results.

this is hard. Irrelevant is defined by propositional equality and propositional equality depends on Nullary.

oh i saw your comment.

@HuStmpHrrr
Copy link
Member Author

I can make Irrelevant into Relation.Nullary but importing Relation.Nullary.Decidable from Relation.Binary.PropositionalEquality is a bit hard to settle. these two modules are imported everywhere.

the cyclic imports are:

  Relation.Binary.PropositionalEquality
  Relation.Nullary.Decidable
  Function.Equivalence
  Relation.Binary.PropositionalEquality

@gallais
Copy link
Member

gallais commented May 29, 2019

Note that #608 introduces Relation.Nullary.Decidable.Core :D

@HuStmpHrrr
Copy link
Member Author

i see, let's wait for your PR to get merged first.

@gallais gallais added the status: blocked-by-issue Progress on this issue or PR is blocked by another issue. label May 29, 2019
@MatthewDaggitt MatthewDaggitt removed the status: blocked-by-issue Progress on this issue or PR is blocked by another issue. label May 31, 2019
@MatthewDaggitt
Copy link
Contributor

Unblocked.

@MatthewDaggitt MatthewDaggitt merged commit f3b17f2 into agda:master Jun 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gallais gallais gallais left review comments

@MatthewDaggitt MatthewDaggitt MatthewDaggitt left review comments

Assignees
No one assigned
Labels
addition
Projects
None yet
Milestone
v1.1
Development

Successfully merging this pull request may close these issues.
3 participants
@HuStmpHrrr @gallais @MatthewDaggitt