Skip to content

Turn binary ++⁺ and related operators infix. #918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

andreasabel
Copy link
Member

@andreasabel andreasabel commented Sep 28, 2019

This is motivated by their proof-relevant use. For instance

      _++⁺_ : All P xs  All P ys  All P (xs ++ ys)

is the operation concatenating two well-typed environments, in case xs and ys are contexts (lists of types) and P is mapping a type to its set of values.

Also: deprecate reverseAcc.

This PR originated from #899 (comment)

This is motivated by their proof-relevant use.  For instance

  _++⁺_ : All P xs → All P ys → All P (xs ++ ys)

is the operation concatenating two well-typed environments, in case xs
and ys are contexts (lists of types) and P is mapping a type to its set
of values.
@andreasabel andreasabel added this to the v1.2 milestone Sep 28, 2019
@MatthewDaggitt
Copy link
Contributor

So no problems with deprecating reverseAcc. My main concern is that the change to infix notation is quite a big non-compatible change and the concatenation function _++_ is quite widely used. Because we're keeping the same name, I don't think we can even mark the old non-infix version as deprecated right?

What do other people think?

@MatthewDaggitt
Copy link
Contributor

@andreasabel not sure if you've had any further thoughts about how to make this change backwards compatible? If you haven't and if it's okay with you, I'm going to bump this to v1.3.

@MatthewDaggitt
Copy link
Contributor

Alternatively maybe we could just include the deprecation of reverseAcc and leave the infix notation for a separate PR?

@MatthewDaggitt MatthewDaggitt modified the milestones: v1.2, v1.3 Oct 29, 2019
@MatthewDaggitt MatthewDaggitt removed this from the v1.3 milestone Mar 11, 2020
@MatthewDaggitt
Copy link
Contributor

@andreasabel are you still keen to work on this in or should I close this?

@MatthewDaggitt MatthewDaggitt deleted the infix-append branch September 21, 2020 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants