refactor: using async_openai::types::Logprobs

[paulhendricks]

Overview:

Refactoring to use async_openai::types::Logprobs

Details:

This change is to be consistent with previous renaming and refactoring for protocols:

• !261 - refactor: using async_openai
• !284 - refactor: rename ChatCompletionRequest to NvCreateChatCompletionRequest
• !291 - refactor: rename ChatCompletionResponse to NvCreateChatCompletionResponse
• !292 - refactor: rename ChatCompletionResponseDelta to NvCreateChatCompletionStreamResponse
• !296 - refactor: removes wrapper for ChatCompletionContent and adds documentation
• !310 - refactor: use async-openai CompletionRequest
• !1383 - refactor: Rename CompletionRequest to NvCreateCompletionRequest
• !1397 - refactor: refactoring to use async_openai::types::CompletionUsage

Where should the reviewer start?

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

• closes GitHub issue: #xxx

Summary by CodeRabbit

• Refactor
  • Updated internal data handling for log probability results to improve consistency with external systems. No changes to user-facing features or functionality.

[copy-pr-bot]

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

[coderabbitai]

Walkthrough

The changes replace a locally defined LogprobResult struct with the Logprobs type from the async_openai crate in two modules. This affects the logprobs field in both CompletionChoice and DeltaChoice structs. Associated imports and the now-unused struct are removed.

Changes

File(s)	Change Summary
lib/llm/src/protocols/openai/completions.rs	Removed local LogprobResult struct, updated logprobs field in CompletionChoice to use async_openai::types::Logprobs, removed unused imports.
lib/llm/src/protocols/openai/completions/aggregator.rs	Updated logprobs field in DeltaChoice to use async_openai::types::Logprobs, removed super import of LogprobResult.

Poem

A bunny hopped through fields of code,
Replacing structs where data flowed.
Out with the old, in with the new,
Logprobs from crates—less to do!
Imports trimmed, the path is clear,
The codebase lighter—let's all cheer!
🐇✨

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0b7cdf5 and db47bc5.

📒 Files selected for processing (2)

• lib/llm/src/protocols/openai/completions.rs (1 hunks)
• lib/llm/src/protocols/openai/completions/aggregator.rs (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (5)

• GitHub Check: pre-commit
• GitHub Check: Build and Test - vllm
• GitHub Check: pre-merge-rust (lib/runtime/examples)
• GitHub Check: pre-merge-rust (.)
• GitHub Check: pre-merge-rust (lib/bindings/python)

🔇 Additional comments (3)

lib/llm/src/protocols/openai/completions/aggregator.rs (2)

21-21: LGTM: Import updated to remove local type reference.

The removal of LogprobResult from the import statement aligns with the refactoring to use external types from the async_openai crate.

---

43-43: LGTM: Field type consistently updated to use external type.

The logprobs field type change from Option<LogprobResult> to Option<async_openai::types::Logprobs> is consistent with the refactoring objective and matches the corresponding change in the main completions module.

lib/llm/src/protocols/openai/completions.rs (1)

93-93: LGTM: Consistent type standardization completed.

The logprobs field type change to async_openai::types::Logprobs successfully completes the refactoring to use external types from the async_openai crate. This change is consistent with the corresponding update in the aggregator module and aligns with the broader effort to standardize protocol handling types across the codebase.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.