-
Notifications
You must be signed in to change notification settings - Fork 613
chore: update sgl version and fix h100 wideep example #2169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThis change updates two Dockerfiles: one updates the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
container/Dockerfile.sglang
(1 hunks)container/Dockerfile.sglang-wideep
(1 hunks)
🔇 Additional comments (1)
container/Dockerfile.sglang (1)
168-175
: Unable to locate upstream tagv0.4.9.post6
The
git checkout v${SGLANG_VERSION}
step incontainer/Dockerfile.sglang
(lines 168–175) will fail if the tag isn’t present. I ran:git ls-remote --tags https://github.com/sgl-project/sglang.git | grep "refs/tags/v0.4.9.post6$"
and didn’t find a matching tag. Please verify that
v0.4.9.post6
exists in the upstream repo (or push/update it), or adjustSGLANG_VERSION
to a valid tag before merging.
/ok to test 06ce5bd |
/ok to test d819879 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a comment to pin version
Summary by CodeRabbit