Skip to content

Conversation

krishung5
Copy link
Contributor

@krishung5 krishung5 commented Aug 20, 2025

Overview:

Updated the pytest markers so that the deepep test will not run the kvbm test in nightly.

Details:

Where should the reviewer start?

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

  • closes GitHub issue: #xxx

Summary by CodeRabbit

  • Documentation

    • Updated command-line help for the model option to display the default dynamically and improved help text formatting. No changes to behavior or defaults.
  • Tests

    • Tagged a vLLM test to run in nightly builds, adjusting its execution schedule without altering test logic.

@krishung5
Copy link
Contributor Author

/ok to test 4931f08

@krishung5 krishung5 changed the title Update pytest markers. Minor fix. fix: Update pytest markers for deepep test. Aug 21, 2025
@krishung5 krishung5 marked this pull request as ready for review August 21, 2025 00:59
@github-actions github-actions bot added the fix label Aug 21, 2025
Copy link
Contributor

coderabbitai bot commented Aug 21, 2025

Walkthrough

Updates the vLLM launch script’s --model help text to display the default via ${MODEL}. Adjusts test metadata by adding the nightly mark to the deepep vLLM test configuration. No changes to parsing logic, defaults, or runtime behavior.

Changes

Cohort / File(s) Summary
Launch script help text
components/backends/vllm/launch/dsr1_dep.sh
Help text now shows default model via ${MODEL} instead of a hard-coded string; minor formatting tweak to help output. No logic changes.
Test marks metadata
tests/serve/test_vllm.py
Adds pytest.mark.nightly to deepep vLLM test marks; no test logic changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • test: Add deepep test for vllm #2534 — Introduces MODEL variable/--model parsing and the deepep test config; this PR refines the help text and updates related test marks, making them directly connected.

Poem

A bunny taps the shell with care,
“Default’s dynamic—see it there!”
Night skies call our tests to flight,
Marked for runs that span the night.
Hop, hop—scripts and specs align,
Carrots compiled, all working fine.

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
components/backends/vllm/launch/dsr1_dep.sh (1)

50-51: Help text now reflects the actual default via ${MODEL} — nice quality-of-life improvement.

Optional consistency tweaks:

  • Allow env override for the default model so MODEL=... ./dsr1_dep.sh -h shows the caller’s intended default without editing the script.
  • Mirror this dynamic pattern for --master-addr and --log-dir as well.

Outside the changed lines, consider:

  • At defaults section (current Line 13):
# before
MODEL="deepseek-ai/DeepSeek-R1"
# after (allows env to override)
MODEL="${MODEL:-deepseek-ai/DeepSeek-R1}"
  • In help text for other options (near Lines 48–49):
echo "  --master-addr ADDR    Master node address (default: ${MASTER_ADDR})"
echo "  --log-dir DIR         Directory for log files (default: ${LOG_DIR})"

I can push a follow-up commit if you’d like these refinements included now.

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 4995843 and 4931f08.

📒 Files selected for processing (2)
  • components/backends/vllm/launch/dsr1_dep.sh (1 hunks)
  • tests/serve/test_vllm.py (1 hunks)
🔇 Additional comments (1)
tests/serve/test_vllm.py (1)

267-272: Nightly marker is registered and excluded by CI

  • pyproject.toml (around line 164) lists "nightly: marks tests to run nightly" under the markers setting, so no PytestUnknownMarkWarning will be raised.
  • The GitHub Actions workflow in .github/workflows/build-and-test.yml invokes pytest with -m "pre_merge or mypy", which inherently omits any tests marked nightly.

No further changes are needed—the heavy H100 tests remain gated to nightly runs as intended.

@krishung5
Copy link
Contributor Author

/ok to test badba57

@krishung5
Copy link
Contributor Author

/ok to test 7c8bf7e

@krishung5 krishung5 merged commit f2089d2 into main Aug 22, 2025
12 of 14 checks passed
@krishung5 krishung5 deleted the krish/minor-fix branch August 22, 2025 16:54
hhzhang16 pushed a commit that referenced this pull request Aug 27, 2025
KrishnanPrash pushed a commit that referenced this pull request Sep 2, 2025
nnshah1 pushed a commit that referenced this pull request Sep 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants