RUST: RegDescList and XferDescList APIs #828
Conversation
|
👋 Hi evgeny-leksikov! Thank you for contributing to ai-dynamo/nixl. Your PR reviewers will review your contribution then trigger the CI to test your changes. 🚀 |
evgeny-leksikov
force-pushed
the
rust_dl_apis
branch
from
a0684b8 to
f89cb64
Compare
evgeny-leksikov
changed the title
evgeny-leksikov
force-pushed
the
rust_dl_apis
branch
from
f89cb64 to
aab2365
Compare
evgeny-leksikov
force-pushed
the
rust_dl_apis
branch
from
aab2365 to
7656037
Compare
evgeny-leksikov
requested review from
gleon99,
mkhazraee and
roiedanino
as code owners
|
/build |
| inner: NonNull<bindings::nixl_capi_reg_dlist_s>, | ||
| _phantom: PhantomData<&'a dyn NixlDescriptor>, | ||
| // Track descriptors internally for comparison purposes | ||
| descriptors: Vec<RegDescriptor>, |
There was a problem hiding this comment.
Why do we need to maintain duplicate storage, with all the implications?
Instead of simply exposing operators from C++...
Am I missing something?
patch.txt
There was a problem hiding this comment.
Index and IndexMut
There was a problem hiding this comment.
It looks like a nice optimization, but I'm afraid some of those APIs may have (or will have in the future) some side effects and checks that we are skipping that way, IMO RegDescList should call the bindings directly, and maybe have another struct called "CachedRegDescList" or make those implementations interchangeable with a configuration flag, making it less error prone, giving a simple workaround in case some incosistencies happen on users end because of this.
|
/build |
- equality operators - set/get - get index Signed-off-by: Evgeny Leksikov <[email protected]>
Add SyncManager absraction to replace manual control Signed-off-by: Evgeny Leksikov <[email protected]>
evgeny-leksikov
force-pushed
the
rust_dl_apis
branch
from
caefe51 to
dbbf296
Compare
4 participants
What?
RegDescList and XferDescList missed APIs: