chore: Include tests and examples in release builds #872
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Hi aranadive! Thank you for contributing to ai-dynamo/nixl. Your PR reviewers will review your contribution then trigger the CI to test your changes. 🚀 |
|
/build |
|
/build |
ovidiusm
reviewed
Oct 7, 2025
|
Related: #869 |
rakhmets
reviewed
Oct 7, 2025
rakhmets
reviewed
Oct 7, 2025
Signed-off-by: Adit Ranadive <[email protected]>
Signed-off-by: Adit Ranadive <[email protected]>
|
/build |
ovidiusm
approved these changes
Oct 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lets build these for release builds. In release builds there is some optimization added that might help with running tests and seeing performance numbers. The asserts are removed in release builds so a new macro was added to check for return status' of the API calls.
What?
Add tests and examples to release builds
Why?
Its useful to have these tests run in release builds when looking at performance.
How?
Remove the buildtype flag. Use a check macro verify that the function calls return correctly.