Skip to content

[TODO] Figure out how to integrate tox --devenv into Makefile #364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
webknjaz opened this issue Aug 30, 2019 · 8 comments · Fixed by #370 or #371
Closed

[TODO] Figure out how to integrate tox --devenv into Makefile #364

webknjaz opened this issue Aug 30, 2019 · 8 comments · Fixed by #370 or #371
Assignees
@webknjaz @hmajid2301
Labels
enhancement good first issue Hacktoberfest help wanted pr-merged

Comments

@webknjaz
Copy link
Member

tox-dev/tox#1326
@webknjaz webknjaz self-assigned this Aug 30, 2019
@hmajid2301
Copy link
Contributor

I can take a look at this.

hmajid2301 pushed a commit to hmajid2301/multidict that referenced this issue Sep 29, 2019
Create the dev environment using tox
a938014 
We can now create the dev environment using tox.  All you have to do is run `make dev`
and tox will create a virtualenv for you.

Fixes aio-libs#364
@webknjaz
Copy link
Member Author

Sure, go ahead!

@hmajid2301 hmajid2301 mentioned this issue Oct 1, 2019
Merged
4 tasks
@helpr helpr bot added the pr-available label Oct 1, 2019
asvetlov pushed a commit that referenced this issue Oct 1, 2019
@asvetlov
Create the dev environment using tox (#370)
8bc1b56 
We can now create the dev environment using tox.  All you have to do is run `make dev`
and tox will create a virtualenv for you.

Fixes #364
@helpr helpr bot added pr-merged and removed pr-available labels Oct 1, 2019
@webknjaz
Copy link
Member Author

webknjaz commented Oct 1, 2019

#370 doesn't do what the issue asks. This is still unsolved.

@webknjaz webknjaz reopened this Oct 1, 2019
@hmajid2301
Copy link
Contributor

sorry i misunderstood what do you need it to do ?

@webknjaz
Copy link
Member Author

webknjaz commented Oct 1, 2019

The issue title says that you need to integrate --devenv CLI option to allow creating dev virtualenvs based on existing toxenv definitions. The PR where this feature was added is linked, so you can track down how it works. We don't need another toxenv in tox.ini.

@hmajid2301
Copy link
Contributor

hmajid2301 commented Oct 1, 2019 •
edited
Loading

so something like make dev VIRTUALENV=.venv PY=3.6
Where the make file target is like

tox --devenv $(VIRTUALENV) -e $(PY)

@webknjaz
Copy link
Member Author

webknjaz commented Oct 1, 2019

-e 3.6 wouldn't work because the correct syntax for this part is -e py36. But we also heavily rely on the current python by using -e python (especially in the CI, using TOXENV var: https://github.com/aio-libs/multidict/blob/37c9c87/.github/workflows/python-tests.yml#L24-L26). This just picks up whatever which python points to, which is great for CI.

I'm currently not 100% sure how this should look for the dev flow: maybe we just need a number of separate targets, or maybe we could just rely on the current Python too. The biggest challenge is to figure out what is the best UX for us.

@webknjaz
Copy link
Member Author

webknjaz commented Oct 1, 2019

@hmajid2301 it could also be helpful if you could record the use of the make target with https://asciinema.org.

@hmajid2301 hmajid2301 mentioned this issue Oct 5, 2019
Merged
4 tasks
@helpr helpr bot added the pr-available label Oct 5, 2019
webknjaz added a commit that referenced this issue Oct 20, 2019
@webknjaz
Add dev-env make target creating a dev env from tox
d14b8ec 
PR #371 by @hmajid2301

* Create the dev environment using tox

We can now create the dev environment using tox.  All you have to do is run `make dev`
and tox will create a virtualenv for you.

Fixes #364

* Make changes

Made changes suggested by webknjaz, also recorded a session with aciinema,
https://asciinema.org/a/GAenipsSb0hZfG8Q8pn2ZWRiR.

* Rename `dev` target into `dev-env`


Co-authored-by: Sviatoslav Sydorenko <[email protected]>
@helpr helpr bot removed the pr-available label Oct 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@webknjaz webknjaz

@hmajid2301 hmajid2301

Labels
enhancement good first issue Hacktoberfest help wanted pr-merged
Projects
None yet
Milestone
No milestone
2 participants
@webknjaz @hmajid2301