Skip to content
This repository was archived by the owner on Jun 4, 2024. It is now read-only.

note that webpack 2 supports import() #14

Merged
merged 1 commit into from
Mar 30, 2017
Merged

note that webpack 2 supports import() #14

merged 1 commit into from
Mar 30, 2017

Conversation

ysangkok
Copy link
Contributor

@ysangkok ysangkok commented Dec 8, 2016

No description provided.

@graingert
Copy link

probably worth deprecating this module now.

@ljharb
Copy link
Collaborator

ljharb commented Jan 25, 2017

@graingert absolutely not, it's still crucial for webpack 1 usage.

@graingert
Copy link

@ljharb but webpack 1 is old and broken now.

@ysangkok
Copy link
Contributor Author

Is it not irrelevant whether one considers this repo obsolete or not? This pull request is just about notifying users that they don't need to use this with Webpack 2. Nothing more, nothing less.

@chicoxyzzy
Copy link

why do you think it's broken? most of people still use it for their projects

@ljharb
Copy link
Collaborator

ljharb commented Jan 25, 2017

@graingert actually webpack 2 is potentially much more broken, because it reifies more strongly incorrect ES module semantics that will definitely break when module loading in node is resolved, which is why Airbnb will likely not use webpack 2, and why I strongly recommend everybody avoid using non-babel import/export semantics (since Babel's broken semantics are popular enough that there will be a migration story).

@xzyfer
Copy link

xzyfer commented Feb 1, 2017

it reifies more strongly incorrect ES module semantics

@ljharb can you please elaborate, or link to relevant discussion?

@ljharb
Copy link
Collaborator

ljharb commented Feb 1, 2017

@xzyfer I'm specifically referring to when you import a CJS module and use named imports (obviously when you import something that's written as an ES module in your own app, things are fine). Everyone's code that's doing import { PropTypes } from 'react' is going to break when node eventually ships modules.

@timdorr
Copy link

timdorr commented Feb 2, 2017

Since this was linked on reddit and before everyone throws @ljharb under the bus, first read this cogent comment explaining the situation. Jordan's just the messenger here. The actual spec is where this is all going down and where you should raise your pitchforks 😄

@FagnerMartinsBrack
Copy link

FagnerMartinsBrack commented Feb 2, 2017

Does anybody have the link of any relevant discussion from Webpack's team about this?

Nevermind, it's right on Reddit, they opened a discussion about this (although as from the date of this comment it only has 2 comments).

@graingert
Copy link

@ysangkok can you rebase this PR?

@ysangkok
Copy link
Contributor Author

@graingert ok now?

@ljharb ljharb merged commit dd50f93 into airbnb:master Mar 30, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants