Skip to content

Spacing issue within Naming Conventions #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
michaelmior opened this issue Nov 5, 2012 · 3 comments
Closed

Spacing issue within Naming Conventions #15

michaelmior opened this issue Nov 5, 2012 · 3 comments

Comments

@michaelmior
Copy link

Under the section about PascalCase in Naming Conventions is the block

// good
function User(options){
  this.name = options.name;
}

As per the Whitespace section, there should be a space between the closing parens and the brace on the function definition.

@hshoff
Copy link
Member

hshoff commented Nov 5, 2012

Good eye 🍻

@hshoff hshoff closed this as completed in 92fa3c7 Nov 5, 2012
@michaelmior
Copy link
Author

That was fast :) Thanks for this btw. Simple and sensible and I find it easier to read than the Google guide.

@hshoff
Copy link
Member

hshoff commented Nov 6, 2012

Wooo, thanks! Hope it helps!

mattgperry pushed a commit to drivetribe/javascript that referenced this issue Aug 22, 2017
…n-component

Update and publish column component
Mykhailiak added a commit to Mykhailiak/javascript that referenced this issue Jan 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants