[guide] [react] add comment about what JS standards are followed #1740
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seen a few pull requests for the React style guide that try to introduce features that aren't yet in stage >= 3 (static class fields for i.e), so I've decided to add a comment to the beginning of the guide. Not sure if this is the right place to put it, but here it is. This disclaimer might help: 1) give the community an idea what standards this guide is based on 2) prevent redundant pull requests
ljharb
reviewed
Feb 20, 2018
react/README.md
Outdated
| @@ -2,6 +2,9 @@ | |||
|
|
|||
| *A mostly reasonable approach to React and JSX* | |||
|
|
|||
| This style guide is based on the standards that are currently prevalent in JavaScript or proposals in stage 3 or greater. | |||
There was a problem hiding this comment.
Let's qualify this by saying it's case-by-case; async/await is still prohibited by this guide which is stage 4, as are class instance fields which are stage 3.
There was a problem hiding this comment.
Fair point. I've went ahead and improved the general idea of this comment by amending the last commit. Let me know how it looks like now.
raunofreiberg
force-pushed
the
patch-1
branch
5 times, most recently
from
b9d080b to
8ad7c4c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seen a few pull requests for the React style guide that try to introduce features that aren't yet in stage >= 3 (static class fields for i.e), so I've decided to add a comment to the beginning of the guide. Not sure if this is the right place to put it, but here it is.
This disclaimer might help: