[linters] update .eslintrc. fixes: #313, #259 #316
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,169 @@ | ||
| { | ||
| "parser": "babel-eslint", | ||
| "env": { | ||
| "browser": true, | ||
| "node": true | ||
| }, | ||
| "ecmaFeatures": { | ||
| "arrowFunctions": true, | ||
| "blockBindings": true, | ||
| "classes": true, | ||
| "defaultParams": true, | ||
| "destructuring": true, | ||
| "forOf": true, | ||
| "generators": false, | ||
| "modules": true, | ||
| "objectLiteralComputedProperties": true, | ||
| "objectLiteralDuplicateProperties": false, | ||
| "objectLiteralShorthandMethods": true, | ||
| "objectLiteralShorthandProperties": true, | ||
| "spread": true, | ||
| "superInFunctions": true, | ||
| "templateStrings": true, | ||
| "jsx": true | ||
| }, | ||
| "rules": { | ||
| /** | ||
| * Strict mode | ||
| */ | ||
| // babel inserts "use strict"; for us | ||
| // http://eslint.org/docs/rules/strict | ||
| "strict": [2, "never"], | ||
|
|
||
| /** | ||
| * ES6 | ||
| */ | ||
| "no-var": 2, // http://eslint.org/docs/rules/no-var | ||
|
|
||
| /** | ||
| * Variables | ||
| */ | ||
| "no-shadow": 2, // http://eslint.org/docs/rules/no-shadow | ||
| "no-shadow-restricted-names": 2, // http://eslint.org/docs/rules/no-shadow-restricted-names | ||
| "no-unused-vars": [2, { // http://eslint.org/docs/rules/no-unused-vars | ||
| "vars": "local", | ||
| "args": "after-used" | ||
| }], | ||
| "no-use-before-define": 2, // http://eslint.org/docs/rules/no-use-before-define | ||
|
|
||
| /** | ||
| * Possible errors | ||
| */ | ||
| "comma-dangle": [2, "never"], // http://eslint.org/docs/rules/comma-dangle | ||
|
There was a problem hiding this comment. we should change this to always and modify our rules. There was a problem hiding this comment. This rule is actually correct here. Should be The following patterns are considered warnings when configured var foo = {
bar: "baz",
qux: "quux",
};
var arr = [1,2,];
foo({
bar: "baz",
qux: "quux",
});The following patterns are not considered warnings when configured var foo = {
bar: "baz",
qux: "quux"
};
var arr = [1,2];
foo({
bar: "baz",
qux: "quux"
});There was a problem hiding this comment. Yes exactly, we should change it to always and change the rules in the style guide :) Trailing commas are a good thing! Hopefully this makes it into ES7: https://github.com/jeffmo/es-trailing-function-commas There was a problem hiding this comment. I would personally disagree with this. But anyway this PR is not the right place to discuss it. Best way is to open a new issue (unless there is/was one already). There was a problem hiding this comment. @goatslacker let's update it for the es6 guide. Should keep the trailing comma rule for es5 since it causes unexpected behavior. There was a problem hiding this comment. oh definitely, I thought this was meant for ES6 though since it has all the options. There was a problem hiding this comment. @goatslacker good point. Let's do a followup PR once we merge ES6. |
||
| "no-cond-assign": [2, "always"], // http://eslint.org/docs/rules/no-cond-assign | ||
| "no-console": 1, // http://eslint.org/docs/rules/no-console | ||
| "no-debugger": 1, // http://eslint.org/docs/rules/no-debugger | ||
| "no-alert": 1, // http://eslint.org/docs/rules/no-alert | ||
| "no-constant-condition": 1, // http://eslint.org/docs/rules/no-constant-condition | ||
| "no-dupe-keys": 2, // http://eslint.org/docs/rules/no-dupe-keys | ||
| "no-duplicate-case": 2, // http://eslint.org/docs/rules/no-duplicate-case | ||
| "no-empty": 2, // http://eslint.org/docs/rules/no-empty | ||
| "no-ex-assign": 2, // http://eslint.org/docs/rules/no-ex-assign | ||
| "no-extra-boolean-cast": 0, // http://eslint.org/docs/rules/no-extra-boolean-cast | ||
| "no-extra-semi": 2, // http://eslint.org/docs/rules/no-extra-semi | ||
| "no-func-assign": 2, // http://eslint.org/docs/rules/no-func-assign | ||
| "no-inner-declarations": 2, // http://eslint.org/docs/rules/no-inner-declarations | ||
| "no-invalid-regexp": 2, // http://eslint.org/docs/rules/no-invalid-regexp | ||
| "no-irregular-whitespace": 2, // http://eslint.org/docs/rules/no-irregular-whitespace | ||
| "no-obj-calls": 2, // http://eslint.org/docs/rules/no-obj-calls | ||
| "no-reserved-keys": 2, // http://eslint.org/docs/rules/no-reserved-keys | ||
| "no-sparse-arrays": 2, // http://eslint.org/docs/rules/no-sparse-arrays | ||
| "no-unreachable": 2, // http://eslint.org/docs/rules/no-unreachable | ||
| "use-isnan": 2, // http://eslint.org/docs/rules/use-isnan | ||
| "block-scoped-var": 2, // http://eslint.org/docs/rules/block-scoped-var | ||
|
|
||
| /** | ||
| * Best practices | ||
| */ | ||
| "consistent-return": 2, // http://eslint.org/docs/rules/consistent-return | ||
| "curly": [2, "multi-line"], // http://eslint.org/docs/rules/curly | ||
| "default-case": 2, // http://eslint.org/docs/rules/default-case | ||
| "dot-notation": [2, { // http://eslint.org/docs/rules/dot-notation | ||
| "allowKeywords": false | ||
| }], | ||
| "eqeqeq": 2, // http://eslint.org/docs/rules/eqeqeq | ||
| "guard-for-in": 2, // http://eslint.org/docs/rules/guard-for-in | ||
| "no-caller": 2, // http://eslint.org/docs/rules/no-caller | ||
| "no-else-return": 2, // http://eslint.org/docs/rules/no-else-return | ||
| "no-eq-null": 2, // http://eslint.org/docs/rules/no-eq-null | ||
| "no-eval": 2, // http://eslint.org/docs/rules/no-eval | ||
| "no-extend-native": 2, // http://eslint.org/docs/rules/no-extend-native | ||
| "no-extra-bind": 2, // http://eslint.org/docs/rules/no-extra-bind | ||
| "no-fallthrough": 2, // http://eslint.org/docs/rules/no-fallthrough | ||
| "no-floating-decimal": 2, // http://eslint.org/docs/rules/no-floating-decimal | ||
| "no-implied-eval": 2, // http://eslint.org/docs/rules/no-implied-eval | ||
| "no-lone-blocks": 2, // http://eslint.org/docs/rules/no-lone-blocks | ||
| "no-loop-func": 2, // http://eslint.org/docs/rules/no-loop-func | ||
| "no-multi-str": 2, // http://eslint.org/docs/rules/no-multi-str | ||
| "no-native-reassign": 2, // http://eslint.org/docs/rules/no-native-reassign | ||
| "no-new": 2, // http://eslint.org/docs/rules/no-new | ||
| "no-new-func": 2, // http://eslint.org/docs/rules/no-new-func | ||
| "no-new-wrappers": 2, // http://eslint.org/docs/rules/no-new-wrappers | ||
| "no-octal": 2, // http://eslint.org/docs/rules/no-octal | ||
| "no-octal-escape": 2, // http://eslint.org/docs/rules/no-octal-escape | ||
| "no-param-reassign": 2, // http://eslint.org/docs/rules/no-param-reassign | ||
| "no-proto": 2, // http://eslint.org/docs/rules/no-proto | ||
| "no-redeclare": 2, // http://eslint.org/docs/rules/no-redeclare | ||
| "no-return-assign": 2, // http://eslint.org/docs/rules/no-return-assign | ||
| "no-script-url": 2, // http://eslint.org/docs/rules/no-script-url | ||
| "no-self-compare": 2, // http://eslint.org/docs/rules/no-self-compare | ||
| "no-sequences": 2, // http://eslint.org/docs/rules/no-sequences | ||
| "no-throw-literal": 2, // http://eslint.org/docs/rules/no-throw-literal | ||
| "no-with": 2, // http://eslint.org/docs/rules/no-with | ||
| "radix": 2, // http://eslint.org/docs/rules/radix | ||
| "vars-on-top": 2, // http://eslint.org/docs/rules/vars-on-top | ||
| "wrap-iife": [2, "any"], // http://eslint.org/docs/rules/wrap-iife | ||
| "yoda": 2, // http://eslint.org/docs/rules/yoda | ||
|
|
||
| /** | ||
| * Style | ||
| */ | ||
| "indent": [2, 2], // http://eslint.org/docs/rules/ | ||
| "brace-style": [2, // http://eslint.org/docs/rules/brace-style | ||
| "1tbs", { | ||
| "allowSingleLine": true | ||
| }], | ||
| "quotes": [ | ||
| 2, "single", "avoid-escape" // http://eslint.org/docs/rules/quotes | ||
| ], | ||
| "camelcase": [2, { // http://eslint.org/docs/rules/camelcase | ||
| "properties": "never" | ||
| }], | ||
| "comma-spacing": [2, { // http://eslint.org/docs/rules/comma-spacing | ||
| "before": false, | ||
| "after": true | ||
| }], | ||
| "comma-style": [2, "last"], // http://eslint.org/docs/rules/comma-style | ||
| "eol-last": 2, // http://eslint.org/docs/rules/eol-last | ||
| "func-names": 1, // http://eslint.org/docs/rules/func-names | ||
| "key-spacing": [2, { // http://eslint.org/docs/rules/key-spacing | ||
| "beforeColon": false, | ||
| "afterColon": true | ||
| }], | ||
| "new-cap": [2, { // http://eslint.org/docs/rules/new-cap | ||
| "newIsCap": true | ||
| }], | ||
| "no-multiple-empty-lines": [2, { // http://eslint.org/docs/rules/no-multiple-empty-lines | ||
| "max": 2 | ||
| }], | ||
| "no-nested-ternary": 2, // http://eslint.org/docs/rules/no-nested-ternary | ||
| "no-new-object": 2, // http://eslint.org/docs/rules/no-new-object | ||
| "no-spaced-func": 2, // http://eslint.org/docs/rules/no-spaced-func | ||
| "no-trailing-spaces": 2, // http://eslint.org/docs/rules/no-trailing-spaces | ||
| "no-wrap-func": 2, // http://eslint.org/docs/rules/no-wrap-func | ||
| "no-underscore-dangle": 0, // http://eslint.org/docs/rules/no-underscore-dangle | ||
| "one-var": [2, "never"], // http://eslint.org/docs/rules/one-var | ||
| "padded-blocks": [2, "never"], // http://eslint.org/docs/rules/padded-blocks | ||
| "semi": [2, "always"], // http://eslint.org/docs/rules/semi | ||
| "semi-spacing": [2, { // http://eslint.org/docs/rules/semi-spacing | ||
| "before": false, | ||
| "after": true | ||
| }], | ||
| "space-after-keywords": 2, // http://eslint.org/docs/rules/space-after-keywords | ||
| "space-before-blocks": 2, // http://eslint.org/docs/rules/space-before-blocks | ||
| "space-before-function-paren": [2, "never"], // http://eslint.org/docs/rules/space-before-function-paren | ||
| "space-infix-ops": 2, // http://eslint.org/docs/rules/space-infix-ops | ||
| "space-return-throw-case": 2, // http://eslint.org/docs/rules/space-return-throw-case | ||
| "spaced-line-comment": 2 // http://eslint.org/docs/rules/spaced-line-comment | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With babel-eslint I ran into issue with some stylistic checks. After babel modifies the raw code, it cannot pass some checks. That might be fixed already and worth doublechecking.