Add reasoning for using double quotes in JSX #534
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There's also that HTML attributes typically (conventionally) use double quotes, not single quotes, but that may not be as compelling a reason to be front-and-center. |
|
Good point @ljharb, added. |
goatslacker
added a commit
that referenced
this pull request
Oct 5, 2015
Add reasoning for using double quotes in JSX
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add reasoning for using double quotes in JSX, since it's the opposite of the recommendation for JS strings. There may be other reasons as well, but the one added here seems the most compelling to me.