fix: false-positive failure for reads expected to fail

aaronsteers · aaronsteers · commit 1c9dc2e6ec08 · 2025-06-13T15:16:48.000-07:00
diff --git a/airbyte_cdk/test/standard_tests/source_base.py b/airbyte_cdk/test/standard_tests/source_base.py
@@ -130,8 +130,8 @@ def test_basic_read(
             catalog=configured_catalog,
         )
 
-        if not result.records:
-            raise AssertionError("Expected records but got none.")  # noqa: TRY003
+        if scenario.expected_outcome.expect_success() and not result.records:
+            raise AssertionError("Expected records but got none.")
 
     def test_fail_read_with_bad_catalog(
         self,

Original file line number	Diff line number	Diff line change
`@@ -130,8 +130,8 @@ def test_basic_read(`
`130`	`130`	`catalog=configured_catalog,`
`131`	`131`	`)`
`132`	`132`
`133`		`- if not result.records:`
`134`		`- raise AssertionError("Expected records but got none.") # noqa: TRY003`
	`133`	`+ if scenario.expected_outcome.expect_success() and not result.records:`
	`134`	`+ raise AssertionError("Expected records but got none.")`
`135`	`135`
`136`	`136`	`def test_fail_read_with_bad_catalog(`
`137`	`137`	`self,`