-
Notifications
You must be signed in to change notification settings - Fork 30
Fix(sdm): module ref issue in python components import #243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
46 commits
Select commit
Hold shift + click to select a range
9973955
skeleton: components module from dynamic text input
aaronsteers 8309f79
refactor / clean up
aaronsteers 399dd7b
add test resource for py_components unit test
aaronsteers 9115757
add fixture for custom py components scenario
aaronsteers 5dc664c
add test
aaronsteers 5be084f
chore: add missing guard statement
aaronsteers 7379eea
chore: remove stale comment
aaronsteers 51cbcbd
checkpoint: passing tests with pokeapi
aaronsteers aaef285
chore: add `poe lock` task definition
aaronsteers e7c3eae
add 'source_the_guardian_api' test resources
aaronsteers 2300f7a
checkpoint: working `check`
aaronsteers 4efcd40
checkpoint: working discover
aaronsteers cb6a4ab
checkpoint: working sync
aaronsteers 051c57b
improve module name parsing
aaronsteers e511a2b
remove unused files
aaronsteers a19b5c1
tidy up
aaronsteers c837745
skip if no creds
aaronsteers c54a73d
cosmetic: cleaner diff
aaronsteers 3f66c46
don't fail when custom components.py is already grafted into filesystem
aaronsteers 75332e8
clean up import code
aaronsteers 67b84a0
clean up imports, implement safety mechanisms and blocked-by-default …
aaronsteers 5805649
fix mypy issues
aaronsteers 3251e5c
Update unit_tests/source_declarative_manifest/test_source_declarative…
aaronsteers 877d721
more clean up
aaronsteers 7531ed0
fix ruff format issue
aaronsteers 5e7e826
add intentionally failing use case
aaronsteers c654ef5
validate input text
aaronsteers 6badf7e
clean up module name parsing
aaronsteers b81ca33
refactor and clean up interfaces
aaronsteers ceab6fd
use monkeypatch for setting env vars
aaronsteers 714360c
full code review and cleanup
aaronsteers c8de81a
apply suggestion
aaronsteers a084e7a
apply suggestion
aaronsteers 0491b99
apply suggestion
aaronsteers 7134340
apply suggestion
aaronsteers bff4dc4
fix lint issues
aaronsteers 15cd254
clean up tests
aaronsteers 3921341
Merge branch 'main' into aj/feat/accept-components-text-input
aaronsteers 6c4e01f
autofix lint issue
aaronsteers 6c81115
fix tests
aaronsteers 1c35577
fix another test
aaronsteers e6b28b6
fix failing test
aaronsteers f29f616
mark full sync as slow test (~60s)
aaronsteers 7ba5417
fix: use `importlib` instead of `sys.modules`
aaronsteers 7df5801
Merge branch 'main' into aj/feat/fix-python-components-ref
aaronsteers 6899cb1
chore: add back missing import
aaronsteers File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.