-
Notifications
You must be signed in to change notification settings - Fork 30
fix: parametrize the connector name in the template code documentation #532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: parametrize the connector name in the template code documentation #532
Conversation
📝 WalkthroughWalkthroughThe update modifies the test file template in the connector CLI code to dynamically insert the actual connector name, replacing a previously hardcoded example. This ensures that generated test files reference the correct connector. No other logic or exported entities are changed. Changes
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
airbyte_cdk/cli/airbyte_cdk/_connector.py (2)
80-88
: Clean up commented-out TestSuite stubI see we still include a commented-out
TestSuite
class stub with placeholders. Could we consider removing this block to reduce clutter in the generated template, since it’s not actively used? wdyt?
155-155
: Add coverage for template renderingThe
.format()
call now correctly injectsconnector_name
, which is perfect. Would you consider adding a unit test for thetest
CLI command to validate that the generated test file contains the actual connector name in its docstring? wdyt?
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
airbyte_cdk/cli/airbyte_cdk/_connector.py
(3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (4)
- GitHub Check: Check: 'source-amplitude' (skip=false)
- GitHub Check: Check: 'source-shopify' (skip=false)
- GitHub Check: Pytest (All, Python 3.11, Ubuntu)
- GitHub Check: Pytest (All, Python 3.10, Ubuntu)
🔇 Additional comments (1)
airbyte_cdk/cli/airbyte_cdk/_connector.py (1)
66-66
: Dynamic connector placeholder in the docstringNice update! The docstring now references
{connector_name}
dynamically, ensuring that generated tests accurately reflect the actual connector. Great improvement!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Nice fix to the hardcoded connector name there.
(You can ignore the unrelated Shopify CI failure.)
update template code block generated by
airbyte-cdk connector test
command to include the connector name in the comments.Summary by CodeRabbit