-
Notifications
You must be signed in to change notification settings - Fork 30
fix: update pytest-fast
poe command to specify unit_tests/
directory, enabling --skipslow
option usage
#565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b8bb7d9
to
69b50db
Compare
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
pyproject.toml
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (9)
- GitHub Check: Check: 'source-amplitude' (skip=false)
- GitHub Check: Check: 'source-hardcoded-records' (skip=false)
- GitHub Check: Check: 'source-pokeapi' (skip=false)
- GitHub Check: Check: 'source-shopify' (skip=false)
- GitHub Check: Pytest (All, Python 3.10, Ubuntu)
- GitHub Check: Pytest (All, Python 3.11, Ubuntu)
- GitHub Check: SDM Docker Image Build
- GitHub Check: Pytest (Fast)
- GitHub Check: Analyze (python)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refines the test tooling and enhances config migration by propagating a config_path
through declarative source constructors.
- Updates the
pytest-fast
task to target theunit_tests/
folder. - Introduces and wires a
config_path
parameter into all declarative source and CLI entrypoints. - Adjusts the
Spec
andManifestDeclarativeSource
classes to migrate & transform configs based onconfig_path
.
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
File | Description |
---|---|
pyproject.toml | Change pytest-fast command to specify unit_tests directory. |
unit_tests/sources/declarative/test_manifest_declarative_source.py | Add fixtures and tests for config migration via config_path . |
unit_tests/sources/declarative/spec/test_spec.py | Remove now-duplicated migration tests in spec tests. |
airbyte_cdk/sources/declarative/yaml_declarative_source.py | Add config_path parameter to __init__ . |
airbyte_cdk/sources/declarative/spec/spec.py | Simplify migrate_config signature; remove args/source. |
airbyte_cdk/sources/declarative/manifest_declarative_source.py | Integrate _migrate_and_transform_config using config_path . |
airbyte_cdk/sources/declarative/concurrent_declarative_source.py | Propagate config_path to superclass. |
airbyte_cdk/cli/source_declarative_manifest/_run.py | Add config_path to CLI run entrypoint. |
Comments suppressed due to low confidence (1)
pyproject.toml:173
- The updated
pytest-fast
command removes the--skipslow
flag, which the PR description indicates should be preserved. Consider adding--skipslow
before the marker expression to skip slow tests as intended.
pytest-fast = {cmd = "poetry run coverage run -m pytest unit_tests --durations=5 --exitfirst -m 'not flaky and not slow and not requires_creds'", help = "Run pytest tests, failing fast and excluding slow tests."}
What
pytest-fast
poe command by specifyingunit_tests/
directory in commandSummary by CodeRabbit