Skip to content

fix(manifest-server): descriptor can be dict #745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 4, 2025
Merged

fix(manifest-server): descriptor can be dict #745

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions airbyte_cdk/manifest_server/api_models/stream.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
fixing type mismatches like slice_descriptor being a string rather than an object.
"""

from typing import Any, Dict, List, Optional
from typing import Any, Dict, List, Optional, Union

from pydantic import BaseModel

Expand Down Expand Up @@ -59,7 +59,7 @@ class StreamReadSlices(BaseModel):
"""Slices of data read from a stream."""

pages: List[StreamReadPages]
slice_descriptor: Optional[str] # This is actually a string at runtime, not Dict[str, Any]
slice_descriptor: Optional[Union[Dict[str, Any], str]] # We're seeing strings at runtime
state: Optional[List[Dict[str, Any]]] = None
auxiliary_requests: Optional[List[AuxiliaryRequest]] = None

Expand Down
Loading