Skip to content

Conversation

pv
Copy link
Collaborator

@pv pv commented Sep 5, 2015

I don't have a Windows machine at hand (only WINE), so this isn't fully tested, but should work.

Fixes gh-319

cc @jorisvandenbossche

@jorisvandenbossche
Copy link

Yes, this seems to work!

@mdboom
Copy link
Collaborator

mdboom commented Sep 6, 2015

Makes sense to me (though I don't have Windows to test on, either)

@pv
Copy link
Collaborator Author

pv commented Sep 6, 2015

Probably safe to merge, seems simple in principle.

pv added a commit that referenced this pull request Sep 6, 2015
Make timeouts also on Windows based on last output timestamp
@pv pv merged commit 4c5d157 into airspeed-velocity:master Sep 6, 2015
@seth-p
Copy link

seth-p commented Oct 18, 2015

FYI, using the latest code from master (0.2.dev818+c07fdbf2) I get a timeout after a bit under 4 minutes when running the Pandas asv tests (64-bit Python 3.4.3 on Windows 7). pandas-dev/pandas#9023 (comment)

@pv
Copy link
Collaborator Author

pv commented Oct 18, 2015

Perhaps the compilation of algos.c just takes more than 120 seconds --- can probably be checked by running the command shown in the log manually?

However, 2 min timeout is probably too short for compilation, and it's not handled correctly anyway (asv quits with error rather than dealing with it).

@seth-p
Copy link

seth-p commented Oct 18, 2015

Perhaps one should be able to specify/override the timeouts (I recall seeing them in three places in the code) on the command line and/or confit file?

On Oct 18, 2015, at 6:43 AM, Pauli Virtanen [email protected] wrote:

Perhaps the compilation of algos.c just takes more than 120 seconds --- can probably be checked by running the command shown in the log manually?

However, 2 min timeout is probably too short for compilation, and it's not handled correctly anyway (asv quits with error rather than dealing with it).


Reply to this email directly or view it on GitHub.

@pv pv deleted the win-timeout branch August 19, 2018 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants