kafka: kafka client zstd compression #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabriel-tincu
force-pushed
the
gabi-kafka-client-zstd-compression
branch
3 times, most recently
from
8af0f81 to
4ca9a84
Compare
jappja
suggested changes
Mar 18, 2020
gabriel-tincu
force-pushed
the
gabi-kafka-client-zstd-compression
branch
from
4ca9a84 to
150c8b3
Compare
ivanyu
approved these changes
Mar 19, 2020
…ependency file, readme and codec checks add 2.1.0 to possible releases being tested / downloadable, skip zstd tests when version is too old add zstd tests to producer tests, add zstandard to tox dep list add New produce request/response classes to support up to V8 produce,(V7 is required for zstd compression) add ProduceResponse fields in use after V5 force broker version onto producers on ver 2.4.0 in unittests, due to inconsitencies with the env var for it produce response api V2 included in the same logic branch as 3 and 5 add proper docstrings to produce request / response classes impose limit on decompress output size on a failed decompress attemtp update producer tests to be more idiomatic with the testing framework
gabriel-tincu
force-pushed
the
gabi-kafka-client-zstd-compression
branch
from
150c8b3 to
cc3c3fd
Compare
ivanyu
approved these changes
Mar 19, 2020
|
hi, guys in aiven. There is an |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For internal review
Add zstd compression, tests for it, and update the API objects for the produce req/resp and fetch req/resp , since the minimal version required for handling zstd compressed requests uses a different api.