Skip to content

Feature/total pages #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

howmuchcomputer
Copy link

  • Fix spec_helper mongoid database configuration
  • Create mongoid.yml
  • Add total_pages method
  • Fix failing test suite
  • Formalize default page limit as constant
  • Add pry to aid with debugging

Copy link
Owner

@ajsharp ajsharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks for this.

@howmuchcomputer
Copy link
Author

Do you understand the error that occurred? Is it something I can fix?

@ajsharp
Copy link
Owner

ajsharp commented May 23, 2017

I haven't updated or maintained this repo in a long time. I've updated the list of ruby versions travis looks for, but there are also problems with spec_helper.rb because it's using a very old version of mongoid configuration there. I'd welcome a fix for that in this PR if you want to do it.

@howmuchcomputer
Copy link
Author

howmuchcomputer commented May 26, 2017

I updated the mongoid config in the original PR. Are you sure it is the mongoid config that is causing the issue? You might have to add a sleep before_script as mentioned here: https://docs.travis-ci.com/user/database-setup/ if it is failing to connect.

Might also be failing from the rspec warnings generated from the use of 'should' matchers. Thoughts? I can update those to 'expect' if necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants