improving execution error handling #473
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
ajthinking
approved these changes
Aug 10, 2025
| @@ -64,7 +65,7 @@ export class ExecutionMemoryFactory { | |||
|
|
|||
| // Initialize runner context | |||
| const context = new NodeRunnerContext(node.id); | |||
| context.status = computer.run({ | |||
| context.status = withNodeExecutionErrorHandling(computer.run.bind(computer), node)({ | |||
There was a problem hiding this comment.
Do we need .bind(computer)?
By doing so we let the run function access this keyword to retrieve the value of the computer? However, I don't see the use case for that here?
There was a problem hiding this comment.
Good catch. I've removed the bind(computer) call.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features
Fixes
Mapnode throws an error.