Skip to content

Fix for issues #1782 & #1767 #1790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Fix for issues #1782 & #1767 #1790

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fcda79e
Measure a node only if it has been found, fixes issue #1782
psegalen Nov 7, 2023
f63dc7d
Round a frame's dimensions to avoid flickering of modals, fixes #1767
psegalen Nov 7, 2023
828da47
Update src/components/devsupport/components/measure/measure.component…
psegalen Dec 7, 2023
af43065
Integrated @raqso's feedback
psegalen Dec 20, 2023
8701781
Update measure.component.tsx following @rklomp advice
psegalen Feb 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/components/devsupport/components/measure/measure.component.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,8 @@ export const MeasureElement: React.FC<MeasureElementProps> = (props): MeasuringE
const boundFrame: Frame = new Frame(
frame.origin.x - window.size.width,
frame.origin.y,
frame.size.width,
frame.size.height,
Math.floor(frame.size.width),
Math.floor(frame.size.height),
);

return bindToWindow(boundFrame, window);
Expand All @@ -68,14 +68,14 @@ export const MeasureElement: React.FC<MeasureElementProps> = (props): MeasuringE
measureSelf();
} else {
const originY = props.shouldUseTopInsets ? y + StatusBar.currentHeight || 0 : y;
const frame: Frame = bindToWindow(new Frame(x, originY, w, h), Frame.window());
const frame: Frame = bindToWindow(new Frame(x, originY, Math.floor(w), Math.floor(h)), Frame.window());
props.onMeasure(frame);
}
};

const measureSelf = (): void => {
const node: number = findNodeHandle(ref.current);
UIManager.measureInWindow(node, onUIManagerMeasure);
if (node) UIManager.measureInWindow(node, onUIManagerMeasure);
};

if (props.force) {
Expand Down