Fork that addresses crashes on API 28

[thellmund]

Hi guys,

I’ve experienced some problems with the library when using API 28 in our app (deprecated canvas methods). Because the library seems to be no longer maintained, I’ve forked the repository and implemented a fix.

You can find it at https://github.com/thellmund/Android-Week-View. Hope this helps anyone who’s had similar problems 😊

[marcoscgdev]

Thank you :D

[fersical]

Que cambios has hecho para que funcione?
Gracias!

[fabien-ml]

Thanks :)

[marcoscgdev]

I have made another fork that solves this problem. This time, it supports API 14+

marcoscgdev/Android-Week-View

This is what I have done:

I have replaced this

canvas.clipRect(0, mHeaderHeight + mHeaderRowPadding * 2, mHeaderColumnWidth, getHeight(), Region.Op.REPLACE);

with this

canvas.save();
canvas.clipRect(0, mHeaderHeight + mHeaderRowPadding * 2, mHeaderColumnWidth, getHeight());
canvas.restore();

So basically I have removed Region.Op.REPLACE and I have added canvas.save(); and canvas.restore();

[thellmund]

@fersical I’ve done exactly what @marcoscgdev has described above. In the future, I want to make more changes, such as improving the scrolling behavior and tweaking the design a little.

[wallforfry]

@thellmund Can you update your readme for your release 2.0 with new interfaces and attributes ?

[thellmund]

@wallforfry I hope to have some time this weekend to work on the library. This will include updating the readme.

[thellmund]

@wallforfry I finally just pushed a new version of the library and an update to the readme. Let me know if there's anything missing or if you have any improvement ideas.

[wallforfry]

@thellmund Thanks for your work !
I've got improvement ideas :

• add minTime and maxTime attributes in WeekView to constraint calendar display to specific range of hours
• allow to change nowLine circle size like for the line thickness

[thellmund]

@wallforfry Great suggestions – I’ll keep them in mind for the next versions 👍

[nivritgupta]

@thellmund this method won't work if I compile my app with API 28

canvas.save();
canvas.clipRect(0, mHeaderHeight + mHeaderRowPadding * 2, mHeaderColumnWidth, getHeight());
canvas.restore();

I am getting the same issue .

[thellmund]

@nivritgupta You’re referencing @marcoscgdev’s fork.