Skip to content

Support hdf5 1.14.0 #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 9, 2023
Merged

Support hdf5 1.14.0 #227

merged 4 commits into from
Jun 9, 2023

Conversation

mulimoen
Copy link
Collaborator

The work done to support 1.13.0 means 1.14.0 is trivial to support

@mulimoen mulimoen requested a review from aldanor January 16, 2023 20:15
@mulimoen mulimoen mentioned this pull request Jan 16, 2023
Open
@mulimoen mulimoen force-pushed the feature/hdf5_1_14 branch 2 times, most recently from 2d39998 to 7eb87b8 Compare January 17, 2023 11:51
@Berrysoft Berrysoft mentioned this pull request Jan 26, 2023
Merged
@mulimoen mulimoen mentioned this pull request Feb 2, 2023
Closed
@jan-kaspar
Copy link

Hi all, what is the status of this PR? I'd be very grateful for the support of 1.14...

BTW: could one ignore the "patch" part here: https://github.com/aldanor/hdf5-rust/blob/master/hdf5-sys/build.rs#L32 ? For example on ArchLinux there is just a number after the dash, https://archlinux.org/packages/community/x86_64/hdf5/, thus failing the regex.

Many thanks in advance!

@mulimoen mulimoen mentioned this pull request Jun 1, 2023
Closed
@aldanor
Copy link
Owner

aldanor commented Jun 1, 2023

@mulimoen I'll take a look at this (and other PRs) on the weekend, is h5d the only change here?

@mulimoen
Copy link
Collaborator Author

mulimoen commented Jun 1, 2023

@aldanor Yes, everything else is covered by the support for 1.13

We should probably remove support for 1.13 at some point considering odd minor versions are "test" versions

@mulimoen mulimoen force-pushed the feature/hdf5_1_14 branch from 7eb87b8 to 5dec121 Compare June 1, 2023 18:08
@mulimoen mulimoen force-pushed the feature/hdf5_1_14 branch from 5dec121 to 38256e5 Compare June 9, 2023 17:33
@mulimoen
Copy link
Collaborator Author

mulimoen commented Jun 9, 2023

Patched versions in e.g. Arch linux currently has the version number "1.14.1-2" which should now be supported

@mulimoen mulimoen force-pushed the feature/hdf5_1_14 branch from 3ec9903 to b024fc8 Compare June 9, 2023 18:13
aldanor
aldanor reviewed Jun 9, 2023
View reviewed changes
@aldanor
Copy link
Owner

aldanor commented Jun 9, 2023

Looks good, thanks! Unless there's anything else to be done here I'll merge this so we can proceed forward.

@aldanor
Copy link
Owner

aldanor commented Jun 9, 2023 •
edited
Loading

Just double checking - would this close #230? (I guess so)

@mulimoen
Copy link
Collaborator Author

mulimoen commented Jun 9, 2023

Feel free to merge. I'll prepare something to rid us of 1.13 later

@mulimoen mulimoen modified the milestone: 230 Jun 9, 2023
@mulimoen mulimoen linked an issue Jun 9, 2023 that may be closed by this pull request
Support both hdf5-1.14 and Ubuntu-latest. #230
Closed
@aldanor aldanor merged commit 12b4067 into aldanor:master Jun 9, 2023
@aldanor aldanor deleted the feature/hdf5_1_14 branch June 9, 2023 18:31
@mulimoen mulimoen mentioned this pull request Jun 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aldanor aldanor aldanor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support both hdf5-1.14 and Ubuntu-latest.
3 participants
@mulimoen @jan-kaspar @aldanor