-
Notifications
You must be signed in to change notification settings - Fork 100
Float16 support #246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Float16 support #246
Conversation
|
@mulimoen In the failures, your (btw I moved the tests under |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the small nits and #247 merged this looks great!
Only run test_issue_223 when deflate filter is avail
Enabled f16/complex for docs.rs builds for both hdf5 and hdf5-types - thanks, good call. As you said above, exhaustive attr might not be the best idea since it would force ourselves to panic when matching which is a bit weird. If it builds green, I think it should be good to go :) |
Looks good to go if green! |
Closes #236 (?)