Fix definition of H5L_info2_t
#261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace incorrect `H5L_info1_t__u` with `H5L_info2_t__u`. Since `H5L_info1_t__u` does not have the same size as `H5L_info2_t__u`, this bug resulted in 8 bytes of stack memory outside the allocated region being overwritten by the hdf5 C-library for example when using `H5Lget_info2`. Since `Debug` can no longer be derived, add a manual implementation for the struct `H5L_info2_t` in order to correctly match the variant of `H5L_info2_t__u` to the link type. Additionally, add methods to access the union fields of `H5L_info2_t__u`.
mulimoen
approved these changes
Nov 8, 2023
|
I pushed one more commit to fix the clippy error in hdf5-sys. Some of the other tests are still failing, but I do not know how this could be connected to my changes. |
|
The clippy and MSRV jobs are known to be failing. On windows we have started to get some random failures, although unrelated to this change |
|
I see, thanks for clarifying! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace incorrect
H5L_info1_t__uwithH5L_info2_t__u. SinceH5L_info1_t__udoes not have the same size asH5L_info2_t__u, this bug resulted in 8 bytes of stack memory outside the allocated region being overwritten by the hdf5 C-library for example when usingH5Lget_info2.Since
Debugcan no longer be derived, add a manual implementation for the structH5L_info2_tin order to correctly match the variant ofH5L_info2_t__uto the link type.Additionally, add methods to access the union fields of
H5L_info2_t__u.