Skip to content

Conversation

Marcin-Radecki
Copy link

This PR adds support for displaying past ABFT scores, via using existing useAbftScores hook. The Staking / Validator stats page was reworked:

  • There are 4 sections now, so data is better organized and not everything is loaded at once
  • Grepping past ABFT scores is now possible for whatever era, as well as past validator performance, so much quicker loading than hardcoded past 4 eras. One component MinMaxAndToggle was extracted to it can be used in the context of querying past eras or sessions.
  • cool Gauge displayed instead of plain label!

Still, there's a code duplication between FinalizerHistoricPerformance and ValidatorHistoricPerformance, which can be further reduced by extracting additional component. For now I proposed separate, to divide heavy-computation of querying past validator/abft scores separately.

Other techncial debt reduced:

  • more common code moved to utils,
  • removed not needed feature which checks if chain name was Aleph - it's not longer needed as azero.dev displays only AlephZero chains,
  • packages/page-staking/src/Performance/useEraSessionBoundaries.tsx now returns current sessions and ending session of the current era, so no undefined anymore

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-156.d1kx19duzu5nc0.amplifyapp.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant