Skip to content

feat(requestOptions): accept requesterOptions #1184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

Haroenv
Copy link
Contributor

@Haroenv Haroenv commented Aug 19, 2020

Sometimes (e.g. local engine, passing ca) it's needed to pass arguments to http[s].request. Since all keys are serialised into data / queryparameters, we need a new excluded key (requesterOptions) to pass arguments to request

Sometimes (e.g. local engine, passing ca) it's needed to pass arguments to http[s].request. Since all keys are serialised into data / queryparameters, we need a new excluded key (`requesterOptions`) to pass arguments to `request`
@Haroenv Haroenv requested review from francoischalifour and removed request for francoischalifour August 19, 2020 15:30
@Haroenv
Copy link
Contributor Author

Haroenv commented Aug 26, 2020

Too much hassle with the typings / bundlesize / tests. Will redo this if I face the issue again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant