-
Notifications
You must be signed in to change notification settings - Fork 223
feat: add transformation bridge methods #1586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like a good idea. Maybe unfortunate that this would be a lot of changes to have as a simple option to saveObject etc. as that would be simpler for the user.
The response type differs so we can't really do that without impacting everyone, and I think the discoverability is better with a standalone method rather than an option, wdyt? |
a9648f0
to
e6ca044
Compare
export function createIngestionClient( | ||
options: SearchClientOptions & ClientTransporterOptions & TransformationOptions | ||
): IngestionClient { | ||
if (!options || !options.transformation || !options.transformation.region) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe check that the value is either us
or eu
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
idea works for me, details should be approved by ingestion or data team :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gg
https://algolia.atlassian.net/browse/DI-3785
this implements the bridge methods in algoliasearch to the ingestion api, in order to reduce friction with the transformation pipeline indexing
related: algolia/api-clients-automation#4852