feat: add transformation bridge methods #1586
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Haroenv
reviewed
May 20, 2025
The response type differs so we can't really do that without impacting everyone, and I think the discoverability is better with a standalone method rather than an option, wdyt? |
shortcuts
force-pushed
the
feat/bridge-transformation-methods
branch
from
a9648f0 to
e6ca044
Compare
millotp
reviewed
May 22, 2025
| export function createIngestionClient( | ||
| options: SearchClientOptions & ClientTransporterOptions & TransformationOptions | ||
| ): IngestionClient { | ||
| if (!options || !options.transformation || !options.transformation.region) { |
There was a problem hiding this comment.
maybe check that the value is either us or eu
Haroenv
reviewed
May 22, 2025
morganleroi
previously approved these changes
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://algolia.atlassian.net/browse/DI-3785
this implements the bridge methods in algoliasearch to the ingestion api, in order to reduce friction with the transformation pipeline indexing
related: algolia/api-clients-automation#4852