Skip to content

docs: add recent changes to our contribution guides #544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 25, 2022

Conversation

shortcuts
Copy link
Member

@shortcuts shortcuts commented May 24, 2022

🧭 What and Why

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/APIC-484

Changes included:

This PR adds documentation for the changes that have happened internally in the past weeks, it could be more exhaustive/detailed but it's a starting point so we don't forget what have been done.

  • Variadic parameters of the CLI
  • Testing headers in the CTS
  • Common tests in the CTS
  • requestOptions in the CTS
  • requestOptions in the clients
  • client's useReadTransporter

🧪 Test

Netlify preview

@shortcuts shortcuts self-assigned this May 24, 2022
@netlify
Copy link

netlify bot commented May 24, 2022

Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit f19c369
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/628e19c37319ea000828fcc4
😎 Deploy Preview https://deploy-preview-544--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@algolia-bot
Copy link
Collaborator

algolia-bot commented May 24, 2022

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

Base automatically changed from docs/endpoints-naming to main May 25, 2022 09:42
@shortcuts shortcuts force-pushed the docs/recent-contributions branch from 78a0460 to 5835dfd Compare May 25, 2022 10:45
@shortcuts shortcuts marked this pull request as ready for review May 25, 2022 10:45
@shortcuts shortcuts requested review from millotp and eunjae-lee May 25, 2022 10:45
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful doc ! It's getting serious

@shortcuts shortcuts requested a review from millotp May 25, 2022 11:28
@@ -38,7 +38,7 @@ Path definition of the paths defined in the [spec file](#specyml-file).

### Send extra options to the template

You might want to send extra information to the generators that have no link with your REST API. To do so, you can add parameters starting matching `x-my-parameter-name` that will be available in the template under `vendorExtensions`.
You might want to send extra information to the generators that have no link with your REST API. To do so, you can add parameters starting with `x-` at the root level of your spec, which will be available in the mustache template under the `vendorExtensions` object.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can work at any level, why precise root level ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bit tricky IIRC because in a nested inline parameter, it won't be passed

We can remove the mention but I preferred to make it clear here

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most object in openapi have a vendorExtensions property, it would be complicated to be exhaustive here but I think it can work in a lot of places

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part was only to mention the implementation from the spec level directly, lmk if you want me to make it broader

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's an obscure feature it's okay to not document it fully

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants