fix(react-renderer): panel now closes when clicking/touching outside #1045
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our current custom renderer implementation with React does not close the panel when clicking outside of it, even when
debug
isfalse
.The deps list in the
useEffect
should not have refs as they are stable, which also means previously the effect only ran once so the event listeners did not get added, which is why I addedautocompleteState.isOpen
as it will create a new ref for panel each time it's opened.I also added a missing
mousedown
event so it works on desktop too.Also removed the
debug
option as it prevents from closing when clicking outside, I don't think it should be kept as users base their implementations on our examples and it's not obvious thatdebug
does this.