-
Notifications
You must be signed in to change notification settings - Fork 85
fix(formatting) Fix JSX element in prop object recursive loop #309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There were the following issues with this Pull Request
You may need to change the commit messages to comply with the repository contributing guidelines. 🤖 This comment was generated by commitlint[bot]. Please report issues here. Happy coding! |
Now supports: <Component props={{ subcomponent: <AnotherComponent />, }} />
363b29f
to
61e042b
Compare
I tested this fix on my project and it works fine, thanks ! |
@vvo sorry to ping you directly. I saw you handled the last version updates on this repo. |
@thomasbertet pinging me is completely OK for those cases and any other Algolia project. |
This PR is only missing a test |
@samwalshnz are you willing to update your PR with a test case ? @vvo I'm not really used to maintain & release OSS, but I offer my help periodically when I find the time. |
@thomasbertet I can merge this and then you add a PR for tests if that works, please do so then we will release. Adding a tests you can just follow previous tests cases |
@thomasbertet Sorry, I'm swamped here at work atm and don't have time to PR with some tests. If you wouldn't mind writing some tests for me, that would be awesome 🙏 |
@samwalshnz I wrote some #312 . If you have time to check if that's what you had in mind, please do :) |
Included in 14.0.2 |
Now supports:
Fixes #307