fix: Show forwarded component name #545
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armandabric
force-pushed
the
fix-forward-ref
branch
from
81e2dd1 to
d9a6a86
Compare
armandabric
changed the title
armandabric
force-pushed
the
fix-forward-ref
branch
from
d9a6a86 to
c886bc6
Compare
armandabric
force-pushed
the
fix-forward-ref
branch
from
c886bc6 to
a56ab16
Compare
dvnrsn
reviewed
Oct 19, 2020
| return ( | ||
| element.type.displayName || | ||
| (element.type.name !== '_default' ? element.type.name : null) || // function name | ||
| (ReactIs.isForwardRef(element) ? element.type.render.displayName : null) || |
There was a problem hiding this comment.
I believe this should be just name render.name
|
What is the status on this PR. I believe I duplicated it here #579 |
|
@armandabric I'm pretty sure that this can be closed now since #617 has landed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recreate the PR #461 closed by error