-
-
Notifications
You must be signed in to change notification settings - Fork 359
Add a docker build option to the 'How to contribute' wiki #656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I would recommend using With that, unless I'm mistaken, you can make build process for docker image, which installs gitbook and next runs only invoke |
I don't see how |
I can look at setting this up if we are still interested |
I’d probably implement it as a dev container |
Related: #691 (comment) |
Here's my first pass on a handful of languages. It's not perfect but may help others so I'm putting it here for now. Will open a PR with more languages soonish.
|
Since we have the docker container now, I believe this can be done. I am adding a hacktoberfest label to this. I think this can also be added to the How to contribute chapter because I will be adding in the wiki contents to the chapter soon. |
what is supposed to done here exactly @leios I would like to pick this up if possible. |
Howdy! Write some documentation for the resources linked in Contributing.md on how to build the dockerfile, and run some of the code within the book. Some of the expectations would be that someone without docker experience could look at the docs you write and be able to build and run the container and use it to run code in the algorithm archive |
Add docker run instructions to how to contribute
|
By running the command
docker run --rm -v "$PWD:/gitbook" -p 4000:4000 billryan/gitbook gitbook install && gitbook serve
one can entirely circumvent installing node.js and gitbook. Maybe this should be added as an alternative to the wiki explaining how to contribute?The command is probably not perfect as one needs to
install
everytime one wants toserve
which increases build time. I didn't quickly find a way around that. Maybe somebody else can?The text was updated successfully, but these errors were encountered: