Fixed conv.jl + Shortened #565
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
june128
added
the
Implementation Edit
|
Yeah, the julia code in the algorithm archive is specifically written to be easy to read and extended to other languages. I'll be honest, this code was originally written as pseudocode and then translated to Julia before the style guide existed, which is why it might be a bit wonky and the index starts as 0. This PR made me realize that the entire chapter should be removed and re-worked heavily because none of the implementations match and the quality of the chapter is far below what I would consider appropriate for the Algorithm Archive. I already took down the video for similar reasons. |
|
Thanks for bringing this to my attention, by the way! |
|
Unfortunately going to have to close this one after #566, but I really appreciate the help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Julia code was incorrect and failed to run for any input. I addressed those issues and also rewrote it in a more Julia style with list comprehensions and generator expressions.