Skip to content

added 1d convolution implementation in python #874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 12, 2021
Merged

added 1d convolution implementation in python #874

merged 4 commits into from
Oct 12, 2021

Conversation

pillarxyz
Copy link
Contributor

No description provided.

@Amaras Amaras added hacktoberfest-accepted lang: python Python programming language Implementation This provides an implementation for an algorithm. (Code and maybe md files are edited.) labels Oct 11, 2021
leios
leios reviewed Oct 11, 2021
View reviewed changes
Copy link
Member

@leios leios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The shape of the output looks correct, but the numbers seem a bit off... I am not sure if this is a problem with the Julia or Python implementation:

[leios@noema julia]$ head cyclic.dat 
0.5037406483790524
0.5111475043733951
0.5184799196039753
0.5257378940707931
0.5329214277738491
0.5400305207131422
0.5470651728886741
0.5540253843004435
0.5609111549484497
0.5677224848326946
[leios@noema julia]$ head ../python/cyclic.dat 
4.128445813851167046e+00
4.189149280450576107e+00
4.249242661958533063e+00
4.308725958375035248e+00
4.367599169700090656e+00
4.425862295933693957e+00
4.483515337075846929e+00
4.540558293126546019e+00
4.596991164085793891e+00
4.652813949953587880e+00

contents/convolutions/1d/code/python/1d_convolution.py Outdated
@@ -0,0 +1,49 @@
from scipy import fft
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't believe we need the fft library for this file

@leios
Copy link
Member

leios commented Oct 11, 2021

Apparently in the C# implementation (#846), there was some problem getting the implementation working because Julia starts counting at 1 and uses a different mod function.

leios
leios approved these changes Oct 12, 2021
View reviewed changes
Copy link
Member

@leios leios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is producing the correct output and the code looks clean. I am happy to merge it!

@leios leios merged commit d81942c into algorithm-archivists:master Oct 12, 2021
@pillarxyz pillarxyz deleted the 1d_conv branch October 12, 2021 13:02
@pillarxyz pillarxyz mentioned this pull request Oct 12, 2021
Merged
leios added a commit that referenced this pull request Oct 25, 2021
@lazyprop @Amaras
@stormofice @jiegillet @leios @berquist @Trashtalk217 @PaddyKe @ShadowMitia @pillarxyz @ntindle @mahdisarikhani @henrikac @Neverik
Tree Traversal: Output Standardization (#857)
2000ab3 
* pep8ify python

* rename Tree_example.py

* standardize python output

* standardize c output

* standardize c++ output

* standardize rust output

* standardize javascript output

* standardize julia output

* Standardized Coconut output

* fix coconut

* standardize go output

* standardize common lisp output

* Verlet Integration: Output standardization (#855)

* Standardize julia output

* Standardize kotlin output

This also fixes a previous bug, which caused the time and velocity
values to not get printed correctly.

* Standardized c output

* Standardized cpp output

* Standardized lisp output

* Standardized fortran output

I was not able to prevent the preceding whitespaces, but they can
just be trimmed.

* Standardized go output

* Standardized java output

* Standardize javascript output

* Standardize nim output

* Standardize python output

* Standardize ruby output

As the original implementation only returned the time and not
the velocity, the code needed to be adjusted a bit. Now it returns
the two values as an array which gets deconstructed and printed.

* Standardize rust output

* Standardize swift output

* Standardized haskell output

* Standardized haskell output (no quote marks)

* attempt at fix for asm

Co-authored-by: Jérémie Gillet <[email protected]>
Co-authored-by: James Schloss <[email protected]>

* standardize php output

* standardize swift output

* removed outdated comments in Coconut implementation

* standardize haskell output

* Fix asm exit codes (#858)

* standardize crystal output

* Flood fill in Coconut (#836)

* Added Barnsley fern in Coconut (+ .editorconfig for Coconut) (#814)

* Added the Jarvis march in Coconut (#734)

* Fix minor typo

* Change folder structure of convolutions (#861)

This puts every chapters' code into its own directory, which is
useful for automatic validation.

* standardize csharp output

* standardize java output

* fix php line numbers and python filename

* fix coconut and python line numbers

* fix minor bug in C

* fix labels and minor bug in go

* minor label fix in python

* Huffman encoding in Coconut (#732)

* Update README.md

Changing readme link to reflect change in twitch url

* Add C# implemenation for 1D Convolutions (#846)

* Add C# implemenation for 1D Convolutions

* Fix off by one error and julia line numbers

* Fix off by one error for linear convolutions

* Fix trailing zero

* Update contents/convolutions/code/csharp/1DConvolution.cs

Co-authored-by: Trashtalk217 <[email protected]>

* Update contents/convolutions/code/csharp/1DConvolution.cs

Co-authored-by: Trashtalk217 <[email protected]>

* Update contents/convolutions/code/csharp/1DConvolution.cs

Co-authored-by: Trashtalk217 <[email protected]>

* Update contents/convolutions/code/csharp/1DConvolution.cs

Co-authored-by: Trashtalk217 <[email protected]>

* Update contents/convolutions/code/csharp/1DConvolution.cs

Co-authored-by: Trashtalk217 <[email protected]>

* Update contents/convolutions/code/csharp/1DConvolution.cs

Co-authored-by: Trashtalk217 <[email protected]>

* Update contents/convolutions/code/csharp/1DConvolution.cs

Co-authored-by: Trashtalk217 <[email protected]>

* Update contents/convolutions/code/csharp/1DConvolution.cs

Co-authored-by: Trashtalk217 <[email protected]>

* Update contents/convolutions/code/csharp/1DConvolution.cs

Co-authored-by: Trashtalk217 <[email protected]>

* Update contents/convolutions/code/csharp/1DConvolution.cs

Co-authored-by: Trashtalk217 <[email protected]>

* Update contents/convolutions/code/csharp/1DConvolution.cs

Co-authored-by: Trashtalk217 <[email protected]>

* Update contents/convolutions/code/csharp/1DConvolution.cs

Co-authored-by: Trashtalk217 <[email protected]>

* Update contents/convolutions/code/csharp/1DConvolution.cs

Co-authored-by: Trashtalk217 <[email protected]>

* Add trailing new line

Co-authored-by: Trashtalk217 <[email protected]>

* IFS Common Lisp implementation (#722)

* first working version

* cleaned up the chaos-game function and added some helpfull comments

* changed the .md file and upped iterations

* Skeleton of the final solution

* Update contents/IFS/IFS.md

Co-authored-by: Eric Berquist <[email protected]>

Co-authored-by: James Schloss <[email protected]>
Co-authored-by: Eric Berquist <[email protected]>

* added MonteCarlo in PowerShell (#760)

* Add Rust implementation for The Barnsley Fern (#818)

* Add Rust implementation for The Barnsley Fern

* Change operators constants and add Cargo.toml

* Fix bug in matrix multiplication

Co-authored-by: James Schloss <[email protected]>

* changing barnsley.md to read the correct coconut file (#867)

* added approximate counting implementation in python (#866)

* added approximate counting implementation in python

* Update approximate_counting.py

* updating approximate_counting.py

* removed redundancies

* fixing linking issues in convolution chapter (#868)

* Add initial devcontainer (#862)

* small changes to convolutional theorem chapter and code to make things more reproduceable (#872)

* added convolutional theorem implementation in python (#869)

* added convolutional theorem implementation in python

* fixed chapter linking

* added comments to the code

* changed random distribution to sawtooth

* corrected previous commit

* fixed comments

Co-authored-by: James Schloss <[email protected]>

* Use `[#]\n` instead of `[#]` for human readable output (#873)

* Add approximate counting algorithm in C (#844)

* Add approximate counting algorithm in C

* Fix typo

Co-authored-by: stormofice <[email protected]>

Co-authored-by: stormofice <[email protected]>
Co-authored-by: James Schloss <[email protected]>

* added 1d convolution implementation in python (#874)

* added 1d convolution implementation in python

* fixed some mistakes in the code so it outputs correct results

* making the code look better

* spacing code properly for readability

* fixing 1d convolution markdown file (#879)

* Add racket setup to devcontainer (#875)

* Normalize inputs for scheme euclid algorithm (#878)

Change inputs to make it consistent with other examples.

* Add initial setup for Swift in devcontainer (#880)

* Add scheme setup to devcontainer (#876)

* Clean up Monte Carlo integration in Racket (#781)

* Clean up Monte Carlo integration in Racket

* Add blank lines in Monte Carlo integration in Clojure

* Change Racket lang include from lisp to racket

* Add C++ code for Flood Fill algorithm (#860)

* fixing chapter to use split-op code (#888)

* use [#]\n for readability

* Implemented stacks and queues in Java (#897)

* Java tree traversal: updated dfsRecursiveInOrderBinary (#899)

* Tree traversal in smalltalk (#453)

* fixed print statements (#901)

* Fixes in PATH that make dlang, emojicode and factor usable (#890)

* fixing huffman encoding for Julia and adding Test (#828)

* JavaScript tree traversal: updated dfsInorder (#902)

* julia: change printf to print

* pep8ify python

* rename Tree_example.py

* standardize python output

* standardize c output

* standardize c++ output

* standardize rust output

* standardize javascript output

Resolved conflict with master (by Amaras)

* standardize julia output

Resolved conflict with master (by Amaras)

* Standardized Coconut output

* fix coconut

* standardize go output

* standardize common lisp output

* standardize php output

* standardize swift output

* removed outdated comments in Coconut implementation

* standardize haskell output

* standardize crystal output

* standardize csharp output

* standardize java output

Resolved the conflict with fixing dfs

* fix php line numbers and python filename

* fix coconut and python line numbers

* fix minor bug in C

* fix labels and minor bug in go

* minor label fix in python

* use [#]\n for readability

* julia: change printf to print

* update Tree.java. remove MainClass.java

Co-authored-by: Sammy Plat <[email protected]>
Co-authored-by: stormofice <[email protected]>
Co-authored-by: Jérémie Gillet <[email protected]>
Co-authored-by: James Schloss <[email protected]>
Co-authored-by: Eric Berquist <[email protected]>
Co-authored-by: Trashtalk217 <[email protected]>
Co-authored-by: PaddyKe <[email protected]>
Co-authored-by: Dimitri Belopopsky <[email protected]>
Co-authored-by: Ayman Lafaz <[email protected]>
Co-authored-by: Nicholas Tindle <[email protected]>
Co-authored-by: Mahdi <[email protected]>
Co-authored-by: Henrik Christensen <[email protected]>
Co-authored-by: Neverik <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leios leios leios approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted Implementation This provides an implementation for an algorithm. (Code and maybe md files are edited.) lang: python Python programming language
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pillarxyz @leios @Amaras