Skip to content

Conversation

NinjaPanda351
Copy link
Contributor

Features

In this PR, I added a screen boundary so that Mario can no longer go offscreen.
Items also no longer get stuck and glitch on monsters.
Jump height was modified so that Mario can make a four block high jump without momentum like in the original game.
Monsters can now be killed by jump-punching the block beneath them.

Did you fully complete the assigned features? Yes

  • Fully completed
  • Partially completed

What features did you Complete?
-Jumping Height modification
-Screen Boundary
-Stuck Items bug fix
-Monsters now die when Mario strikes a block that is under it

How did you go about implementing your features? I first spent a lot of time to understand the codebase and how everything interacts. I then systematically chose bugs/features that I felt were needed and implemented them.

Bugs

Did you introduce any bugs or potential ones?

  • Yes
  • No

Contributors to the Feature

Jayden Fausto

  • Indicate the name of participants in this PR

Final check

Have you filled out this document and gave the pull request a descriptive name (Up on top of this document and the GitHub PR title)? Answer Yes and that means you are good to go! Thank you for your contribution.

  • [X ] Yes
  • No

NinjaPanda351 and others added 5 commits February 18, 2025 19:30
Mario is now constrained by the camera and cannot go off screen.
When Mario hits a block from below, it now kills enemies standing on top.
@algorithm0r algorithm0r merged commit ecb42ff into algorithm0r:master Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants