purge existing panic operations #284
Conversation
louyuting
added
the
kind/enhancement
binbin0325
force-pushed
the
purge_existing_panic
branch
from
6a531e9 to
d083f66
Compare
Codecov Report
@@ Coverage Diff @@
## master #284 +/- ##
==========================================
+ Coverage 51.09% 51.17% +0.07%
==========================================
Files 79 79
Lines 4026 4057 +31
==========================================
+ Hits 2057 2076 +19
- Misses 1679 1692 +13
+ Partials 290 289 -1
Continue to review full report at Codecov.
|
| // sampleCount is the number of slots | ||
| // intervalInMs is the time length of sliding window | ||
| // sampleCount and intervalInMs must be positive and intervalInMs%sampleCount == 0, | ||
| // the validation must be done before call NewBucketLeapArray |
There was a problem hiding this comment.
How about change the param to bucket span time and bucket count in future？ Is it more easy to use?
There was a problem hiding this comment.
Is your meaning bucket count and bucketLengthMs?
There was a problem hiding this comment.
We could file another PR to enhance here
There was a problem hiding this comment.
I'll have a try, please add an issue and assign to me.
There was a problem hiding this comment.
You can submit a issue.
louyuting
force-pushed
the
purge_existing_panic
branch
from
56c1f60 to
43690ed
Compare
Describe what this PR does / why we need it
A panic operation will cause the program to exit
Does this pull request fix one issue?
fixes:#278
Describe how you did it
Describe how to verify it
go test ./...
Special notes for reviews