-
-
Notifications
You must be signed in to change notification settings - Fork 43
fix: cleaned up and added roles aswell as comments #1010
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideExtends the role count cog by adding three missing OS roles to the configuration. Class diagram for updated OS roles configuration in rolecount.pyclassDiagram
class RoleConfig {
+int id
+str name
}
class RoleCountCog {
+os_ids: List[RoleConfig]
+lang_ids: List[RoleConfig]
}
RoleCountCog --> "*" RoleConfig : contains
%% Highlight new roles
class EndeavourOS_Role {
+id = 1386793599483646044
+name = "_endeavouros"
}
class Solus_Role {
+id = 1367198731115434035
+name = "_solus"
}
class GreyQuestion_Role {
+id = 1297922102917206109
+name = "grey_question"
}
RoleCountCog ..> EndeavourOS_Role : added
RoleCountCog ..> Solus_Role : added
RoleCountCog ..> GreyQuestion_Role : added
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @cherryl1k - I've reviewed your changes - here's some feedback:
- Consider moving the static role ID list into an external config (JSON/YAML) or database so you don’t need to modify the code every time a new role is added.
- The role entries aren’t sorted—keeping them in alphabetical or numeric order will make future diffs and lookups much clearer.
- It might be helpful to add a startup check that logs a warning if any configured role ID isn’t found in the guild, so typos or missing roles are caught early.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider moving the static role ID list into an external config (JSON/YAML) or database so you don’t need to modify the code every time a new role is added.
- The role entries aren’t sorted—keeping them in alphabetical or numeric order will make future diffs and lookups much clearer.
- It might be helpful to add a startup check that logs a warning if any configured role ID isn’t found in the guild, so typos or missing roles are caught early.
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Deploying tux with
|
Latest commit: |
98c78ae
|
Status: | ✅ Deploy successful! |
Preview URL: | https://bfbc0b39.tux-afh.pages.dev |
Branch Preview URL: | https://rolecount-fix-missing-roles.tux-afh.pages.dev |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1010 +/- ##
======================================
Coverage ? 9.61%
======================================
Files ? 123
Lines ? 10422
Branches ? 1280
======================================
Hits ? 1002
Misses ? 9316
Partials ? 104
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
46a9616
to
02379b9
Compare
d1efe3f
to
6a9d1a4
Compare
6a9d1a4
to
98c78ae
Compare
added some roles that i left out in my first pull request (there's a lot of roles sorry)
aswell as comments
and this needs to be tested in the main .gg/linux server first before being merged
Summary by Sourcery
Bug Fixes: