Skip to content

Added rotation behaviour. #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Added rotation behaviour. #9

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a23a68d
Added rotation behaviour.
Aarkham Nov 20, 2022
664eac4
Code style adapted to be in line with the rest of the code.
Aarkham Nov 26, 2022
fdb7051
Improved drag to not work when the click occurs outside the widget.
Aarkham Mar 6, 2023
43d06b6
Ajustes por actualización de imgui.
Aarkham Apr 24, 2023
f537e22
Now it's possible to specify the min and max draw angles.
Aarkham Oct 22, 2023
36beff2
Fixed flag check for absolute behaviour
Aarkham Nov 4, 2023
05d256a
Added wrap around mode for rotate behaviours.
Aarkham Nov 4, 2023
f1a5984
Update README.md
Aarkham Nov 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
143 changes: 140 additions & 3 deletions imgui-knobs.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,46 @@

namespace ImGuiKnobs {
namespace detail {



//Re-maps a number from one range to another.
//Numbers outside the range are not clamped to 0 and 1.
template<typename T>
inline T Map(const T& aValue,const T& aIStart,const T& aIStop,const T& aOStart,const T& aOStop)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Map is only used inside MapC, can you inline it there?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I copied it from code I was using. As I did not know if you wanted to merge I did not modified it.

{
return aOStart + (aOStop - aOStart) * ((aValue - aIStart) / (aIStop - aIStart));
}


// Re-Maps clamped
template<typename T>
inline T MapC(const T& aValue,const T& aIStart,const T& aIStop,const T& aOStart,const T& aOStop)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use kebab case, and maybe use a more descriptive name, like map_range_clamped. Also don't add the a for paramteres, just name them value, in_start, out_stop, etc.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I'll try to do this week end.

{
if(aValue<=aIStart)
{
return aOStart;
}
else if(aValue>=aIStop)
{
return aOStop;
}
return Map<T>(aValue,aIStart,aIStop,aOStart,aOStop);
}

inline float GetAngle(const ImVec2& aPos,const ImVec2& aMousePos)
{
ImVec2 dir(aMousePos.x-aPos.x,aMousePos.y-aPos.y);
float angle=atan2(-dir.y,-dir.x);
angle+=(3.141592f*2.5f);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use the Pi constant instead? Here and other places

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, sorry. I was using the previous version with IMGUIKNOBS_PI using double and forgot to fix it when I updated.

angle=fmod(angle,3.141592f*2.0f);

return angle;
}




void draw_arc1(ImVec2 center, float radius, float start_angle, float end_angle, float thickness, ImColor color, int num_segments) {
ImVec2 start = {
center[0] + cosf(start_angle) * radius,
Expand Down Expand Up @@ -66,23 +106,120 @@ namespace ImGuiKnobs {
float angle_cos;
float angle_sin;


bool WrapAround(DataType p_value,DataType prev_value, DataType v_min, DataType v_max) const noexcept
{
static const float epsilon=0.05f;

if( (p_value>=v_max*(1.0f-epsilon) && prev_value<=v_min*(1.0f+epsilon))
|| (p_value<=v_min*(1.0f+epsilon) && prev_value>=v_max*(1.0f-epsilon))
)
{
return true;
}

return false;
}

bool RotateBehavior(DataType *p_value, DataType v_min, DataType v_max,float speed,bool absolute_rot)
{
ImGuiIO& imgui_io=ImGui::GetIO();


if(absolute_rot)
{
ImVec2 mouse_pos=imgui_io.MousePos;
float input_angle=GetAngle(center,mouse_pos);
DataType prev_value=*p_value;

*p_value=MapC(input_angle,0.25f*3.141592f,1.75f*3.141592f,1.0f*v_min,1.0f*v_max);

if( WrapAround(*p_value,prev_value,v_min,v_max) || fabs(*p_value-prev_value)>(v_min+v_max)*0.75f)
{
*p_value=prev_value;
}

value_changed=(prev_value!=*p_value);
}
else
{
ImVec2 mouse_pos,mouse_pos_prev;

if(imgui_io.MouseDownDuration[0]>0.0f)
{
mouse_pos=imgui_io.MousePos;

mouse_pos_prev=imgui_io.MousePos;
mouse_pos_prev.x-=imgui_io.MouseDelta.x;
mouse_pos_prev.y-=imgui_io.MouseDelta.y;
}
else
{
mouse_pos=imgui_io.MouseClickedPos[0];
mouse_pos_prev=imgui_io.MouseClickedPos[0];
}

float input_angle_prev=GetAngle(center,mouse_pos_prev);
float input_angle=GetAngle(center,mouse_pos);

if(input_angle_prev!=input_angle)
{
DataType prev_value=*p_value;
//if(!speed) // speed == 0 is changed in knob_with_drag
{
DataType r=(v_max-v_min)*IMGUIKNOBS_PI*0.4f;
speed=r;
}

*p_value+=MapC(input_angle-input_angle_prev,-2.0f*IMGUIKNOBS_PI,2.0f*IMGUIKNOBS_PI,-speed,speed);
if (*p_value < v_min)
*p_value = v_min;
if (*p_value > v_max)
*p_value = v_max;

if(WrapAround(*p_value,prev_value,v_min,v_max) || fabs(input_angle-input_angle_prev)>IMGUIKNOBS_PI)
{
*p_value=prev_value;
value_changed=false;
}
else
{
value_changed=true;
}
}
else
{
value_changed=false;
}
}

return value_changed;
}


knob(const char *_label, ImGuiDataType data_type, DataType *p_value, DataType v_min, DataType v_max, float speed, float _radius, const char *format, ImGuiKnobFlags flags) {
radius = _radius;
t = ((float) *p_value - v_min) / (v_max - v_min);
auto screen_pos = ImGui::GetCursorScreenPos();
center = {screen_pos[0] + radius, screen_pos[1] + radius};

// Handle dragging
ImGui::InvisibleButton(_label, {radius * 2.0f, radius * 2.0f});
auto gid = ImGui::GetID(_label);
ImGuiSliderFlags drag_flags = 0;
if (!(flags & ImGuiKnobFlags_DragHorizontal)) {
if((flags & (ImGuiKnobFlags_RotateRelative|ImGuiKnobFlags_RotateAbsolute))) {
value_changed = RotateBehavior(p_value, v_min, v_max,speed,flags==ImGuiKnobFlags_RotateAbsolute);
}
else{
if (!(flags & ImGuiKnobFlags_DragHorizontal))
drag_flags |= ImGuiSliderFlags_Vertical;

value_changed = ImGui::DragBehavior(gid, data_type, p_value, speed, &v_min, &v_max, format, drag_flags);
}
value_changed = ImGui::DragBehavior(gid, data_type, p_value, speed, &v_min, &v_max, format, drag_flags);


angle_min = IMGUIKNOBS_PI * 0.75f;
angle_max = IMGUIKNOBS_PI * 2.25f;
center = {screen_pos[0] + radius, screen_pos[1] + radius};
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this moved?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The center value is needed in RotateBehavior.

is_active = ImGui::IsItemActive();
is_hovered = ImGui::IsItemHovered();
angle = angle_min + (angle_max - angle_min) * t;
Expand Down
2 changes: 2 additions & 0 deletions imgui-knobs.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ enum ImGuiKnobFlags_ {
ImGuiKnobFlags_NoInput = 1 << 1,
ImGuiKnobFlags_ValueTooltip = 1 << 2,
ImGuiKnobFlags_DragHorizontal = 1 << 3,
ImGuiKnobFlags_RotateRelative = 1 << 4,
ImGuiKnobFlags_RotateAbsolute = 1 << 5,
};

typedef int ImGuiKnobVariant;
Expand Down