Skip to content
This repository was archived by the owner on Apr 13, 2024. It is now read-only.

chore: add Node.js 10 #27

Closed
wants to merge 2 commits into from
Closed

chore: add Node.js 10 #27

wants to merge 2 commits into from

Conversation

DanielRuf
Copy link

Description
This adds Node.js 10 to the CI tests.

Motivation and Context
Test the latest stable release of Node.js.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@DanielRuf
Copy link
Author

See nodegit/nodegit#1490

@DanielRuf
Copy link
Author

So it does not yet work with Node.js 10.

@alxpez
Copy link
Owner

alxpez commented May 7, 2018

@DanielRuf Thanks for your insterest,

Honestly nodegit is a bit of a pain at this point (every time I deploy a release, it takes around 5 minutes to build nodegit binaries from the soruce code), I have to do some test to see if I can get rid of it.

I'll close the PR for now

@alxpez alxpez closed this May 7, 2018
@DanielRuf
Copy link
Author

DanielRuf commented May 8, 2018

I have to do some test to see if I can get rid of it.

This is not the issue but the incompatibility.

I would kept it open to track the status of the dependency and try a nodegit update when there is one available.

But I guess I'll try again in the next days and weeks.

@DanielRuf DanielRuf deleted the chore/add-nodejs-10 branch May 8, 2018 04:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants