Start all private names in amaranth.hdl with an underscore
#1062
+167
−162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1062 +/- ##
==========================================
- Coverage 86.54% 86.54% -0.01%
==========================================
Files 41 41
Lines 7159 7157 -2
Branches 1712 1711 -1
==========================================
- Hits 6196 6194 -2
Misses 797 797
Partials 166 166 ☔ View full report in Codecov by Sentry. |
This change completely breaks the library. It is done separately just to make sure git tracks renames as such.
This change completes commit 9dc0617 and makes all the tests pass. It corresponds with the ongoing langauge reference documentation effort. Fixes amaranth-lang#781.
whitequark
force-pushed
the
hide-amaranth.hdl-innards
branch
from
c40a8f5 to
ee58c5a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change tracks the reference documentation effort started in #1058.
Fixes #781.