Skip to content

Implement RFC 42: Const from shape-castable. #1063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

zyp
Copy link
Contributor

@zyp zyp commented Jan 30, 2024

No description provided.

@zyp zyp requested a review from whitequark as a code owner January 30, 2024 22:05
Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5dd1223) 86.54% compared to head (d5aab78) 86.55%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1063   +/-   ##
=======================================
  Coverage   86.54%   86.55%           
=======================================
  Files          41       41           
  Lines        7157     7162    +5     
  Branches     1711     1712    +1     
=======================================
+ Hits         6194     6199    +5     
- Misses        796      797    +1     
+ Partials      167      166    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@whitequark whitequark added this to the 0.5 milestone Jan 30, 2024
Copy link
Member

@whitequark whitequark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. This will require a changelog entry and reference documentation update (if I get to writing reference docs for Const by the point this is merged).

@whitequark whitequark added this pull request to the merge queue Feb 6, 2024
Merged via the queue into amaranth-lang:main with commit 5e2f3b7 Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants