Skip to content

hdl._ast: make Shape immutable and hashable. #1146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

wanda-phi
Copy link
Member

Fixes #1127.

Copy link

codecov bot commented Feb 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (24a3928) 85.59% compared to head (8aba7c0) 85.60%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1146      +/-   ##
==========================================
+ Coverage   85.59%   85.60%   +0.01%     
==========================================
  Files          42       42              
  Lines        8411     8419       +8     
  Branches     1993     1995       +2     
==========================================
+ Hits         7199     7207       +8     
+ Misses       1016     1015       -1     
- Partials      196      197       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@whitequark whitequark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@whitequark whitequark added this pull request to the merge queue Feb 16, 2024
Merged via the queue into amaranth-lang:main with commit 6058ad3 Feb 16, 2024
@wanda-phi wanda-phi deleted the shape-immutable branch February 16, 2024 15:27
@whitequark whitequark added this to the 0.5 milestone Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Make Shape immutable and hashable
2 participants