-
Notifications
You must be signed in to change notification settings - Fork 178
back.rtlil: Opportunistically trim zero and sign extension on operands. #1152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
back.rtlil: Opportunistically trim zero and sign extension on operands. #1152
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1152 +/- ##
==========================================
+ Coverage 90.79% 90.84% +0.04%
==========================================
Files 44 44
Lines 10519 10571 +52
Branches 2561 2577 +16
==========================================
+ Hits 9551 9603 +52
Misses 777 777
Partials 191 191 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a little cursed and I'm worried about the potential for bugs, but we have to start doing randomized testing either way...
I would be much happier with at least a few tests, I think.
Yeah.... I do want to add some tests for this, but unfortunately this'll have to wait until #1100 lands, we don't really have good infrastructure for that right now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works on my machine™! Thank you.
Since it's addressing a regresstion I'm not going to block this on #1100, @wanda-phi, your call on when to merge this. |
Oh, just noticed the branch name :D |
a0ab64a
to
f5f3d20
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regretfully, LFGTM.
Fixes #1148.