Skip to content

Implement RFC 50: Print and string formatting. #1190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 11, 2024
Merged

Implement RFC 50: Print and string formatting. #1190

merged 1 commit into from
Mar 11, 2024

Conversation

wanda-phi
Copy link
Member

@wanda-phi wanda-phi commented Mar 6, 2024 •
edited
Loading

TODO:

  • documentation
  • add support for missing format specifiers to yosys (moved to tracking issue)

@codecov Codecov
Copy link

codecov bot commented Mar 6, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 88.64143% with 51 lines in your changes are missing coverage. Please review.

Project coverage is 89.42%. Comparing base (161b014) to head (69e868d).
Report is 2 commits behind head on main.

Files Patch % Lines
amaranth/back/rtlil.py 25.42% 39 Missing and 5 partials ⚠️
amaranth/asserts.py 55.55% 3 Missing and 1 partial ⚠️
amaranth/sim/_pyrtl.py 94.73% 1 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1190      +/-   ##
==========================================
+ Coverage   89.23%   89.42%   +0.19%     
==========================================
  Files          43       43              
  Lines        8751     9139     +388     
  Branches     2072     2175     +103     
==========================================
+ Hits         7809     8173     +364     
- Misses        765      790      +25     
+ Partials      177      176       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

whitequark
whitequark reviewed Mar 6, 2024
View reviewed changes
@wanda-phi wanda-phi force-pushed the print branch 2 times, most recently from 6094c63 to 504ad1c Compare March 6, 2024 11:29
whitequark
whitequark reviewed Mar 6, 2024
View reviewed changes
Copy link
Member

@whitequark whitequark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few very minor comments

@wanda-phi wanda-phi mentioned this pull request Mar 10, 2024
Closed
wanda-phi
wanda-phi commented Mar 10, 2024
View reviewed changes
@wanda-phi wanda-phi force-pushed the print branch 2 times, most recently from 851476c to 6f3f9ac Compare March 11, 2024 08:50
@wanda-phi wanda-phi marked this pull request as ready for review March 11, 2024 09:10
whitequark
whitequark approved these changes Mar 11, 2024
View reviewed changes
Copy link
Member

@whitequark whitequark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this massive undertaking!

@whitequark whitequark enabled auto-merge March 11, 2024 09:37
@whitequark whitequark added this pull request to the merge queue Mar 11, 2024
Merged via the queue into amaranth-lang:main with commit bfe541a Mar 11, 2024
@wanda-phi wanda-phi deleted the print branch March 11, 2024 09:56
wanda-phi added a commit to wanda-phi/amaranth that referenced this pull request Mar 15, 2024
@wanda-phi
hdl._ir: Fix fallout from amaranth-lang#1190, add more tests.
27dddf4
github-merge-queue bot pushed a commit that referenced this pull request Mar 16, 2024
@wanda-phi @whitequark
hdl._ir: Fix fallout from #1190, add more tests.
18b54de
@whitequark whitequark added this to the 0.5 milestone Mar 19, 2024
purdeaandrei added a commit to purdeaandrei/amaranth-exercises that referenced this pull request Aug 4, 2024
@purdeaandrei
Get rid of some deprecation warnings
546cb2a 
It's been deprecated since Amaranth commit bfe541a6d7f63b7a8402d86aa51e741c7d1c97bd (2024-03-06)
See PR: amaranth-lang/amaranth#1190
Deprecated since Amaranth release v0.5.0
@purdeaandrei purdeaandrei mentioned this pull request Aug 4, 2024
Merged
rviollette pushed a commit to rviollette/amaranth-exercises that referenced this pull request Feb 6, 2025
@purdeaandrei
Get rid of some deprecation warnings
68f54f5 
It's been deprecated since Amaranth commit bfe541a6d7f63b7a8402d86aa51e741c7d1c97bd (2024-03-06)
See PR: amaranth-lang/amaranth#1190
Deprecated since Amaranth release v0.5.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whitequark whitequark whitequark approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
0.5
Development

Successfully merging this pull request may close these issues.
2 participants
@wanda-phi @whitequark