Skip to content

Implement RFC 51: Add ShapeCastable.from_bits and amaranth.lib.data.Const. #1202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 19, 2024
Merged

Implement RFC 51: Add ShapeCastable.from_bits and amaranth.lib.data.Const. #1202

merged 1 commit into from
Mar 19, 2024

Conversation

wanda-phi
Copy link
Member

@wanda-phi wanda-phi commented Mar 14, 2024 •
edited by whitequark
Loading

TODO:

  • tests
  • documentation
  • add custom Const subclasses for Struct/Union? deferred

@wanda-phi wanda-phi force-pushed the from-bits branch 2 times, most recently from c0ccc99 to 88f603e Compare March 14, 2024 19:33
@codecov Codecov
Copy link

codecov bot commented Mar 14, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.62%. Comparing base (598cf8d) to head (6d15d55).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1202      +/-   ##
==========================================
+ Coverage   89.50%   89.62%   +0.11%     
==========================================
  Files          43       43              
  Lines        9616     9722     +106     
  Branches     2314     2332      +18     
==========================================
+ Hits         8607     8713     +106     
  Misses        820      820              
  Partials      189      189

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

whitequark
whitequark reviewed Mar 18, 2024
View reviewed changes
whitequark
whitequark reviewed Mar 18, 2024
View reviewed changes
whitequark
whitequark reviewed Mar 18, 2024
View reviewed changes
whitequark
whitequark reviewed Mar 18, 2024
View reviewed changes
whitequark
whitequark reviewed Mar 18, 2024
View reviewed changes
whitequark
whitequark reviewed Mar 18, 2024
View reviewed changes
whitequark
whitequark reviewed Mar 18, 2024
View reviewed changes
@wanda-phi wanda-phi force-pushed the from-bits branch 2 times, most recently from ec00bac to f4100fb Compare March 18, 2024 21:50
@wanda-phi wanda-phi marked this pull request as ready for review March 18, 2024 21:50
whitequark
whitequark approved these changes Mar 19, 2024
View reviewed changes
Copy link
Member

@whitequark whitequark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@whitequark whitequark added this pull request to the merge queue Mar 19, 2024
@whitequark whitequark added this to the 0.5 milestone Mar 19, 2024
Merged via the queue into amaranth-lang:main with commit d6bf47d Mar 19, 2024
@whitequark whitequark mentioned this pull request Mar 19, 2024
Closed
@wanda-phi wanda-phi deleted the from-bits branch March 19, 2024 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whitequark whitequark whitequark approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
0.5
Development

Successfully merging this pull request may close these issues.
2 participants
@wanda-phi @whitequark