Skip to content

lib.io: Implement *Port from RFC 55. #1214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

wanda-phi
Copy link
Member

@wanda-phi wanda-phi commented Mar 18, 2024

No description provided.

@wanda-phi wanda-phi requested a review from whitequark as a code owner March 18, 2024 21:01
@wanda-phi wanda-phi marked this pull request as draft March 18, 2024 21:04
Copy link

codecov bot commented Mar 18, 2024

Codecov Report

Attention: Patch coverage is 98.26087% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 89.50%. Comparing base (7445760) to head (186d0bf).

Files Patch % Lines
amaranth/build/res.py 71.42% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1214      +/-   ##
==========================================
+ Coverage   89.39%   89.50%   +0.11%     
==========================================
  Files          43       43              
  Lines        9516     9616     +100     
  Branches     2283     2314      +31     
==========================================
+ Hits         8507     8607     +100     
+ Misses        820      819       -1     
- Partials      189      190       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wanda-phi wanda-phi changed the title build.res: Implement __len__ on *Port. lib.io: Implement *Port from RFC 55. Mar 18, 2024
@wanda-phi wanda-phi marked this pull request as ready for review March 18, 2024 23:29
@whitequark whitequark added this pull request to the merge queue Mar 18, 2024
Merged via the queue into amaranth-lang:main with commit 598cf8d Mar 19, 2024
@wanda-phi wanda-phi deleted the port-len branch March 19, 2024 00:30
@whitequark whitequark added this to the 0.5 milestone Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants