Skip to content

lib.io: Implement *Buffer from RFC 55. #1215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

wanda-phi
Copy link
Member

No description provided.

@wanda-phi wanda-phi requested a review from whitequark as a code owner March 19, 2024 02:42
Copy link

codecov bot commented Mar 19, 2024

Codecov Report

Attention: Patch coverage is 95.81395% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 89.78%. Comparing base (d6bf47d) to head (1e88d42).
Report is 5 commits behind head on main.

Files Patch % Lines
amaranth/lib/io.py 95.81% 6 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1215      +/-   ##
==========================================
+ Coverage   89.62%   89.78%   +0.16%     
==========================================
  Files          43       43              
  Lines        9722     9929     +207     
  Branches     2332     2396      +64     
==========================================
+ Hits         8713     8915     +202     
- Misses        819      823       +4     
- Partials      190      191       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@whitequark whitequark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

The docstrings are intentionally not linked from docs/stdlib/io.rst for the time being; I will take care of that later.

@whitequark whitequark added this pull request to the merge queue Mar 22, 2024
Merged via the queue into amaranth-lang:main with commit 456dcae Mar 22, 2024
@wanda-phi wanda-phi deleted the lib-io-buffer branch March 22, 2024 03:01
@whitequark whitequark added this to the 0.5 milestone Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants